support for electron 32

[steinmetz85]

With electron 32.0.1 and its underlying v8 version 12.8, there are mulitple errors when building NAN modules:

nan.h(700,39): error C2039: "IdleNotificationDeadline" ist kein Member von "v8::Isolate"
nan.h(2560,8): error C2039: "SetAccessor" ist kein Member von "v8::ObjectTemplate"
nan.h(2654,15): error C2039: "SetAccessor" ist kein Member von "v8::Object"
nan.h(2730,56): error C2440: "": "initializer list" kann nicht in "v8::NamedPropertyHandlerConfiguration" konvertiert werden
nan_scriptorigin.h(19,1): error C2664: "v8::ScriptOrigin::ScriptOrigin(v8::Localv8::Value,int,int,bool,int,v8::Localv8::Value,bool,bool,bool,v8::Localv8::Data)" : Konvertierung von Argument 1 von "v8::Isolate *" in "v8::Localv8::Value" nicht möglich

[agracio]

In Electron v31 the following lines appeared as warnings

node_modules\nan\nan.h(700,39): warning C4996: 'v8::Isolate::IdleNotificationDeadline' : Use MemoryPressureNotification() to influence the GC schedule. 
node_modules\nan\nan.h(2654,15): warning C4996: 'v8::Object::SetAccessor': Use SetNativeDataProperty instead 
node_modules\nan\nan.h(2730,56): warning C4996: 'v8::NamedPropertyHandlerConfiguration ::NamedPropertyHandlerConfiguration': Provide interceptor callbacks with new signatures instead (NamedPropertyXxxCallback)

node_modules\nan\nan_scriptorigin.h(19,23): warning C4996: 'v8::ScriptOrigin::ScriptOrigin': Use constructor without the isolate. 
node_modules\nan\nan_scriptorigin.h(23,23): warning C4996: 'v8::ScriptOrigin::ScriptOrigin': Use constructor without the isolate. 
node_modules\nan\nan_scriptorigin.h(30,23): warning C4996: 'v8::ScriptOrigin::ScriptOrigin': Use constructor without the isolate. 

In Electron v32 it now throws these errors:

node_modules\nan\nan.h(700,39): error C2039: 'IdleNotificationDeadline': is not a member of 'v8::Isolate' 
node_modules\nan\nan.h(2560,8): error C2039: 'SetAccessor': is not a member of 'v8::ObjectTemplate' 
node_modules\nan\nan.h(2608,8): error C2039: 'SetAccessor': is not a member of 'v8::ObjectTemplate'
node_modules\nan\nan.h(2654,15): error C2039: 'SetAccessor': is not a member of 'v8::Object' 
node_modules\nan\nan.h(2730,56): error C2440: '<function-style-cast>': cannot convert
from 'initializer list' to 'v8::NamedPropertyHandlerConfiguration'
node_modules\nan\nan.h(2800,58): error C2440: '<function-style-cast>': cannot convert
from 'initializer list' to 'v8::IndexedPropertyHandlerConfiguration'

node_modules\nan\nan_scriptorigin.h(19,23): error C2664: 'v8::ScriptOrigin::ScriptOrig in(v8::Local<v8::Value>,int,int,bool,int,v8::Local<v8::Value>,bool,bool,bool,v8::Local<v8::Data>)': cannot convert argument 1 from 'v8::Isolate *' to 'v8::Local<v8::Value>' 
node_modules\nan\nan_scriptorigin.h(23,23): error C2664: 'v8::ScriptOrigin::ScriptOrig in(v8::Local<v8::Value>,int,int,bool,int,v8::Local<v8::Value>,bool,bool,bool,v8::Local<v8::Data>)': cannot convert argument 1 from 'v8::Isolate *' to 'v8::Local<v8::Value>' 
node_modules\nan\nan_scriptorigin.h(30,23): error C2664: 'v8::ScriptOrigin::ScriptOrig in(v8::Local<v8::Value>,int,int,bool,int,v8::Local<v8::Value>,bool,bool,bool,v8::Local<v8::Data>)': cannot convert argument 1 from 'v8::Isolate *' to 'v8::Local<v8::Value>' 

[kkoopa]

Based on v8/v8@6ec8839 since V8 12.5.59 there is a need to use the Local<Name> version of SetAccessor instead. IdleNotificationDeadline is deprecated with no replacement since V8 11.3.218 and removed in v8/v8@c8c168f V8 12.7.41.

[agracio]

Could this used be to replace IdleNotificationDeadline in a different part of the code?

node_modules\nan\nan.h(700,39): warning C4996: 'v8::Isolate::IdleNotificationDeadline' : Use MemoryPressureNotification() to influence the GC schedule. 

[kkoopa]

Based on some comments in linked commits, MemoryPressurrNotification seems to correspond more to some GCLimit-ish-named thing not exposed by NAN. I do not see a straight replacement for this, so it will just be deprecated deplaced by a no-op.

…

On August 22, 2024 10:42:43 AM GMT+03:00, agracio ***@***.***> wrote: Could this used be to replace `IdleNotificationDeadline` in a different part of the code? ``` node_modules\nan\nan.h(700,39): warning C4996: 'v8::Isolate::IdleNotificationDeadline' : Use MemoryPressureNotification() to influence the GC schedule. ``` -- Reply to this email directly or view it on GitHub: #973 (comment) You are receiving this because you commented. Message ID: ***@***.***>

[kkoopa]

I created an untested PR that should deal with this. Please try it out.

[agracio]

I am getting this error

node_modules\nan\nan.h(2567,138): error C1012: unmatched parenthesis: missing ')'

#if defined(V8_MAJOR_VERSION) && (V8_MAJOR_VERSION > 12 || (V8_MAJOR_VERSION == 12 && defined(V8_MINOR_VERSION) && V8_MINOR_VERSION >= 5)

// this part has 3 opening '(' and 2 closing ')'
&& (V8_MAJOR_VERSION > 12 || (V8_MAJOR_VERSION == 12 && defined(V8_MINOR_VERSION) && V8_MINOR_VERSION >= 5)

Same in lines 2619, 2672

nan_callbacks_12_inl.h missing closing ')' in lines 264, 308, 374, 418, 550, 592, 659, 701

[kkoopa]

Thanks for reporting, I have updated the PR.

[agracio]

Ok this one is on me, instead of just building your branch of nan and finding all the errors encountered on build I should have changed the files in my project's node_modules/nan.
Apologies for adding additional work when I could have checked it myself.

node_modules\nan\nan.h(2673,15): error C2664: 'v8::Maybe<bool> v8::Object::SetNativeDataProperty(v8::Local<v8::Context>,v8::Local<v8::Name>,v8::AccessorNameGetterCallback,v8::AccessorNameSetterCallback,v8::Lo cal<v8::Value>,v8::PropertyAttribute,v8::SideEffectType,v8::SideEffectType)': cannot convert argument 6 from 'v8::AccessCo ntrol' to 'v8::PropertyAttribute' 
node_modules\nan\nan.h(2752,56): error C2440: '<function-style-cast>': cannot convert from 'initializer list' to 'v8::NamedPropertyHandlerConfiguration'
node_modules\nan\nan.h(2822,58): error C2440: '<function-style-cast>': cannot convert from 'initializer list' to 'v8::IndexedPropertyHandlerConfiguration' 

[kkoopa]

Alright, so v8::AccessControl has been removed. This requires a long dance of deprecating and splitting out functions with default arguments to overloads in order to remove the argument from Nan::SetAccessor. It is doable, but tedious. I do not see what is wrong with the Property Handler Configurations, they are supposed to correspond to this constructor.

[kkoopa]

Apparently AccessControl is already being silently ignored on the other form of Nan::SetAccessor, so I won't bother cleaning it. I fixed the SetNativeDataProperty call, but I still cannot tell what is wrong with creating the property handler configurations.

[agracio]

After the fix now getting even more very strange errors.
But this time only one '<function-style-cast>': cannot convert from 'initializer list' to 'v8::IndexedPropertyHandlerConfiguration'

nan_callbacks_12_inl.h(277,34): error C2039: 'Get': is not a member of 'Nan::ReturnValue<T>' [C:\path\electron-edge-js\build\edge_coreclr.vcxproj]
nan_callbacks_12_inl.h(277,34): error C2039:         with [C:\path\electron-edge-js\build\edge_coreclr.vcxproj]
nan_callbacks_12_inl.h(277,34): error C2039:         [ [C:\path\electron-edge-js\build\edge_coreclr.vcxproj]
nan_callbacks_12_inl.h(277,34): error C2039:             T=v8::Value [C:\path\electron-edge-js\build\edge_coreclr.vcxproj]
nan_callbacks_12_inl.h(277,34): error C2039:         ] [C:\path\electron-edge-js\build\edge_coreclr.vcxproj]
nan_callbacks_12_inl.h(322,34): error C2039: 'Get': is not a member of 'Nan::ReturnValue<T>' [C:\path\electron-edge-js\build\edge_coreclr.vcxproj]
nan_callbacks_12_inl.h(322,34): error C2039:         with [C:\path\electron-edge-js\build\edge_coreclr.vcxproj]
nan_callbacks_12_inl.h(322,34): error C2039:         [ [C:\path\electron-edge-js\build\edge_coreclr.vcxproj]
nan_callbacks_12_inl.h(322,34): error C2039:             T=v8::Value [C:\path\electron-edge-js\build\edge_coreclr.vcxproj]
nan_callbacks_12_inl.h(322,34): error C2039:         ] [C:\path\electron-edge-js\build\edge_coreclr.vcxproj]
nan_callbacks_12_inl.h(387,34): error C2039: 'Get': is not a member of 'Nan::ReturnValue<T>' [C:\path\electron-edge-js\build\edge_coreclr.vcxproj]
nan_callbacks_12_inl.h(387,34): error C2039:         with [C:\path\electron-edge-js\build\edge_coreclr.vcxproj]
nan_callbacks_12_inl.h(387,34): error C2039:         [ [C:\path\electron-edge-js\build\edge_coreclr.vcxproj]
nan_callbacks_12_inl.h(387,34): error C2039:             T=v8::Boolean [C:\path\electron-edge-js\build\edge_coreclr.vcxproj]
nan_callbacks_12_inl.h(387,34): error C2039:         ] [C:\path\electron-edge-js\build\edge_coreclr.vcxproj]
nan_callbacks_12_inl.h(431,34): error C2039: 'Get': is not a member of 'Nan::ReturnValue<T>' [C:\path\electron-edge-js\build\edge_coreclr.vcxproj]
nan_callbacks_12_inl.h(431,34): error C2039:         with [C:\path\electron-edge-js\build\edge_coreclr.vcxproj]
nan_callbacks_12_inl.h(431,34): error C2039:         [ [C:\path\electron-edge-js\build\edge_coreclr.vcxproj]
nan_callbacks_12_inl.h(431,34): error C2039:             T=v8::Integer [C:\path\electron-edge-js\build\edge_coreclr.vcxproj]
nan_callbacks_12_inl.h(431,34): error C2039:         ] [C:\path\electron-edge-js\build\edge_coreclr.vcxproj]
nan_callbacks_12_inl.h(562,34): error C2039: 'Get': is not a member of 'Nan::ReturnValue<T>' [C:\path\electron-edge-js\build\edge_coreclr.vcxproj]
nan_callbacks_12_inl.h(562,34): error C2039:         with [C:\path\electron-edge-js\build\edge_coreclr.vcxproj]
nan_callbacks_12_inl.h(562,34): error C2039:         [ [C:\path\electron-edge-js\build\edge_coreclr.vcxproj]
nan_callbacks_12_inl.h(562,34): error C2039:             T=v8::Value [C:\path\electron-edge-js\build\edge_coreclr.vcxproj]
nan_callbacks_12_inl.h(562,34): error C2039:         ] [C:\path\electron-edge-js\build\edge_coreclr.vcxproj]
nan_callbacks_12_inl.h(606,34): error C2039: 'Get': is not a member of 'Nan::ReturnValue<T>' [C:\path\electron-edge-js\build\edge_coreclr.vcxproj]
nan_callbacks_12_inl.h(606,34): error C2039:         with [C:\path\electron-edge-js\build\edge_coreclr.vcxproj]
nan_callbacks_12_inl.h(606,34): error C2039:         [ [C:\path\electron-edge-js\build\edge_coreclr.vcxproj]
nan_callbacks_12_inl.h(606,34): error C2039:             T=v8::Value [C:\path\electron-edge-js\build\edge_coreclr.vcxproj]
nan_callbacks_12_inl.h(606,34): error C2039:         ] [C:\path\electron-edge-js\build\edge_coreclr.vcxproj]
nan_callbacks_12_inl.h(671,34): error C2039: 'Get': is not a member of 'Nan::ReturnValue<T>' [C:\path\electron-edge-js\build\edge_coreclr.vcxproj]
nan_callbacks_12_inl.h(671,34): error C2039:         with [C:\path\electron-edge-js\build\edge_coreclr.vcxproj]
nan_callbacks_12_inl.h(671,34): error C2039:         [ [C:\path\electron-edge-js\build\edge_coreclr.vcxproj]
nan_callbacks_12_inl.h(671,34): error C2039:             T=v8::Boolea n [C:\path\electron-edge-js\build\edge_coreclr.vcxproj]
nan_callbacks_12_inl.h(671,34): error C2039:         ] [C:\path\electron-edge-js\build\edge_coreclr.vcxproj]
nan_callbacks_12_inl.h(713,34): error C2039: 'Get': is not a member of 'Nan::ReturnValue<T>' [C:\path\electron-edge-js\build\edge_coreclr.vcxproj]
nan_callbacks_12_inl.h(713,34): error C2039:         with [C:\path\electron-edge-js\build\edge_coreclr.vcxproj]
nan_callbacks_12_inl.h(713,34): error C2039:         [ [C:\path\electron-edge-js\build\edge_coreclr.vcxproj]
nan_callbacks_12_inl.h(713,34): error C2039:             T=v8::Integer [C:\path\electron-edge-js\build\edge_coreclr.vcxproj]
nan_callbacks_12_inl.h(713,34): error C2039:         ] [C:\path\electron-edge-js\build\edge_coreclr.vcxproj]
nan.h(2717,30): error C2072: 'deleter_': initialization of a function  [C:\path\electron-edge-js\build\edge_coreclr.vcxproj]
nan.h(2759,33): error C2065: 'deleter_': undeclared identifier [C:\path\electron-edge-js\build\edge_coreclr.vcxproj]
nan.h(2828,58): error C2440: '<function-style-cast>': cannot convert from 'initializer list' to 'v8::IndexedPropertyHandlerConfiguration' [C:\path\electron-edge-js\build\edge_coreclr.vcxproj]

EDIT: If that helps your branch of nan builds 'Test' build and runs npm test after that without any problems.

[kkoopa]

Okay, that one about missing Get was my oversight. I missed that the CallbackInfo object was from NAN and does not have a way of getting the actual value. I tried to do something with a friend function to get around it, but it still might need some massaging before it compiles. I currently do not have anything set up with such a new V8 version so I cannot easily test myself.

[agracio]

Well here is a new list of errors

nan_callbacks_12_inl.h(19,35): error C7568: argument list missing after assumed function template 'ReturnValue' 
nan_callbacks_12_inl.h(19,29): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int 
nan_callbacks_12_inl.h(19,35): error C2144: syntax error: 'unknown-type' should be preceded by ')' 
nan_callbacks_12_inl.h(19,35): error C2144: syntax error: 'unknown-type' should be preceded by ';' 
nan_callbacks_12_inl.h(19,53): error C2059: syntax error: ')' 
nan_callbacks_12_inl.h(19,54): error C2988: unrecognizable template declaration/definition 
nan_callbacks_12_inl.h(19,54): error C2143: syntax error: missing ';'  before '<end Parse>' 
nan_callbacks_12_inl.h(20,1): error C2988: unrecognizable template de claration/definition 
nan_callbacks_12_inl.h(20,1): error C2059: syntax error: '}' 
nan_callbacks_12_inl.h(20,1): error C2143: syntax error: missing ';' before '}' 
nan_callbacks_12_inl.h(122,10): error C2977: 'Nan::imp::ReturnValue':  too many template arguments 
nan_callbacks_12_inl.h(122,25): error C2955: 'Nan::imp::ReturnValue':  use of class template requires template argument list 
nan_callbacks_12_inl.h(122,25): error C2027: use of undefined type 'Nan::imp::ReturnValue' 
nan_callbacks_12_inl.h(168,10): error C2977: 'Nan::imp::ReturnValue':  too many template arguments 
nan_callbacks_12_inl.h(168,25): error C2955: 'Nan::imp::ReturnValue':  use of class template requires template argument list 
nan_callbacks_12_inl.h(168,25): error C2027: use of undefined type 'Nan::imp::ReturnValue' 
nan_callbacks_12_inl.h(285,42): error C2977: 'Nan::imp::ReturnValue':  too many template arguments 
nan_callbacks_12_inl.h(285,58): error C2955: 'Nan::imp::ReturnValue':  use of class template requires template argument list 
nan_callbacks_12_inl.h(286,13): error C2027: use of undefined type 'Nan::imp::ReturnValue' 
nan_callbacks_12_inl.h(300,39): error C2664: 'void (v8::Local<v8::Str ing>,const Nan::PropertyCallbackInfo<v8::Value> &)': cannot convert argument 2 from 'Nan::imp::PropertyCallbackInfo<v8::Va lue>' to 'const Nan::PropertyCallbackInfo<v8::Value> &'  nan_callbacks_12_inl.h(301,37): error C2027: use of undefined type 'N an::imp::ReturnValue' 
nan_callbacks_12_inl.h(301,15): error C2672: 'Nan::imp::imp::GetReturnValue': no matching overloaded function found 
nan_callbacks_12_inl.h(345,46): error C2664: 'void (v8::Local<v8::String>,v8::Local<v8::Value>,const Nan::PropertyCallbackInfo<v8::Value> &)': cannot convert argument 3 from 'Nan::imp::Proper tyCallbackInfo<v8::Value>' to 'const Nan::PropertyCallbackInfo<v8::Value> &' 
nan_callbacks_12_inl.h(346,37): error C2027: use of undefined type 'Nan::imp::ReturnValue' 
nan_callbacks_12_inl.h(346,15): error C2672: 'Nan::imp::imp::GetReturnValue': no matching overloaded function found 
nan_callbacks_12_inl.h(388,12): error C2664: 'void (const Nan::PropertyCallbackInfo<v8::Array> &)': cannot convert argument 1 from 'Nan::imp::PropertyCallbackInfo<v8::Array>' to 'const Nan::P ropertyCallbackInfo<v8::Array> &' 
nan_callbacks_12_inl.h(410,39): error C2664: 'void (v8::Local<v8::String>,const Nan::PropertyCallbackInfo<v8::Boolean> &)': cannot convert argument 2 from 'Nan::imp::PropertyCallbackInfo<v8:: Boolean>' to 'const Nan::PropertyCallbackInfo<v8::Boolean> &' 
nan_callbacks_12_inl.h(411,37): error C2027: use of undefined type 'Nan::imp::ReturnValue' 
nan_callbacks_12_inl.h(411,15): error C2672: 'Nan::imp::imp::GetReturnValue': no matching overloaded function found 
nan_callbacks_12_inl.h(454,39): error C2664: 'void (v8::Local<v8::String>,const Nan::PropertyCallbackInfo<v8::Integer> &)': cannot convert argument 2 from 'Nan::imp::PropertyCallbackInfo<v8:: Integer>' to 'const Nan::PropertyCallbackInfo<v8::Integer> &' 
nan_callbacks_12_inl.h(455,37): error C2027: use of undefined type 'Nan::imp::ReturnValue' 
nan_callbacks_12_inl.h(455,15): error C2672: 'Nan::imp::imp::GetReturnValue': no matching overloaded function found 
nan_callbacks_12_inl.h(585,19): error C2664: 'void (uint32_t,const Nan::PropertyCallbackInfo<v8::Value> &)': cannot convert argument 2 from 'Nan::imp::PropertyCallbackInfo<v8::Value>' to 'con st Nan::PropertyCallbackInfo<v8::Value> &' 
nan_callbacks_12_inl.h(586,37): error C2027: use of undefined type 'Nan::imp::ReturnValue' 
nan_callbacks_12_inl.h(586,15): error C2672: 'Nan::imp::imp::GetReturnValue': no matching overloaded function found 
nan_callbacks_12_inl.h(629,26): error C2664: 'void (uint32_t,v8::Local<v8::Value>,const Nan::PropertyCallbackInfo<v8::Value> &)': cannot convert argument 3 from 'Nan::imp::PropertyCallbackInf o<v8::Value>' to 'const Nan::PropertyCallbackInfo<v8::Value> &' 
nan_callbacks_12_inl.h(630,37): error C2027: use of undefined type 'Nan::imp::ReturnValue' 
nan_callbacks_12_inl.h(630,15): error C2672: 'Nan::imp::imp::GetReturnValue': no matching overloaded function found 
nan_callbacks_12_inl.h(673,12): error C2664: 'void (const Nan::PropertyCallbackInfo<v8::Array> &)': cannot convert argument 1 from 'Nan::imp::PropertyCallbackInfo<v8::Array>' to 'const Nan::P ropertyCallbackInfo<v8::Array> &' 
nan_callbacks_12_inl.h(694,19): error C2664: 'void (uint32_t,const Nan::PropertyCallbackInfo<v8::Boolean> &)': cannot convert argument 2 from 'Nan::imp::PropertyCallbackInfo<v8::Boolean>' to 'const Nan::PropertyCallbackInfo<v8::Boolean> &' 
nan_callbacks_12_inl.h(695,37): error C2027: use of undefined type 'Nan::imp::ReturnValue' 
nan_callbacks_12_inl.h(695,15): error C2672: 'Nan::imp::imp::GetReturnValue': no matching overloaded function found 
nan_callbacks_12_inl.h(736,19): error C2664: 'void (uint32_t,const Nan::PropertyCallbackInfo<v8::Integer> &)': cannot convert argument 2 from 'Nan::imp::PropertyCallbackInfo<v8::Integer>' to 'const Nan::PropertyCallbackInfo<v8::Integer> &' 
nan_callbacks_12_inl.h(737,37): error C2027: use of undefined type 'Nan::imp::ReturnValue' 
nan_callbacks_12_inl.h(737,15): error C2672: 'Nan::imp::imp::GetReturnValue': no matching overloaded function found 
nan_new.h(21,15): error C2039: 'To': is not a member of 'Nan' 
nan_new.h(21,22): error C2275: 'v8::Integer': expected an expression instead of a type 
nan_new.h(21,34): error C2039: 'ToLocalChecked': is not a member of ' v8::Local<v8::Integer>' 
nan_new.h(28,15): error C2039: 'To': is not a member of 'Nan' 
nan_new.h(28,22): error C2275: 'v8::Int32': expected an expression instead of a type 
nan_new.h(28,32): error C2039: 'ToLocalChecked': is not a member of ' v8::Local<v8::Integer>' 
nan_new.h(35,15): error C2039: 'To': is not a member of 'Nan' 
nan_new.h(35,22): error C2275: 'v8::Uint32': expected an expression instead of a type 
nan_new.h(35,22): error C1003: error count exceeds 100; stopping compilation