Fix CoffeeScript CJS + ESM #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // empty object is returned for the module's exports. | ||
| // the import does NOT hit ESMLoader or its CJS strategy. | ||
| ok(!stdout.includes('Hello from CommonJS!'), 'Named CommonJS import fails'); | ||
| ok(stdout.includes('Hello from CommonJS!'), 'Named CommonJS import fails'); |
There was a problem hiding this comment.
And what did the trick was adding module._compile, it looks like?
There was a problem hiding this comment.
Yes adding module._compile was the critical piece. coffeescript/register called it in their implementation so I looked to see what was different here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added call to
module._compileto fix CJS loading in combo mode.Also refactored out
compilehelper method for compiling CoffeeScript.