feat: Allow to select WASM platform when using Docker.#215
Merged
ShogunPanda merged 2 commits intonodejs:mainfrom Jan 18, 2023
Merged
feat: Allow to select WASM platform when using Docker.#215ShogunPanda merged 2 commits intonodejs:mainfrom
ShogunPanda merged 2 commits intonodejs:mainfrom
Conversation
Contributor
Author
|
@dnlup As you originally work on this, WDYT? |
RafaelGSS
reviewed
Jan 14, 2023
Member
|
I would recommend we bump it to v18, September is close too. |
ShogunPanda
force-pushed
the
platform-wasm
branch
from
0382ff2 to
7d3cb3c
Compare
Contributor
Author
|
Done, updated Docker to use 18. |
Contributor
Author
|
@mcollina @RafaelGSS Green light to merge this? |
Contributor
Author
No, it's not. Docker is only used within the build process so it's not and user facing API. |
Contributor
|
Sorry @ShogunPanda , I missed this. Great work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added a
process.env.WASM_PLATFORMto the build script to select the platform to build Docker image for.Also, I've updated Docker image to be smaller and to use Node 16 to build.
Fixes #208.