c-headers: do not list PRI as a valid HTTP method #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PRI gets special treatment (parse preamble and error) and even though it is parsed and allowed after `HTTP/1.x` - it is not technically a method that could appear in the request parsed with llhttp. Remove the method from the list of HTTP methods in C headers to prevent confusion and breakage of `body-parser`.
BethGriggs
approved these changes
Apr 20, 2021
indutny
added a commit
that referenced
this pull request
Apr 22, 2021
PRI gets special treatment (parse preamble and error) and even though it is parsed and allowed after `HTTP/1.x` - it is not technically a method that could appear in the request parsed with llhttp. Remove the method from the list of HTTP methods in C headers to prevent confusion and breakage of `body-parser`. PR-URL: #105 Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Member
Author
|
Landed in 3f85eb7, thank you! |
Member
Author
|
Released in v6.0.1. |
alex-dev-2012
added a commit
to alex-dev-2012/llhttp
that referenced
this pull request
Jul 29, 2025
PRI gets special treatment (parse preamble and error) and even though it is parsed and allowed after `HTTP/1.x` - it is not technically a method that could appear in the request parsed with llhttp. Remove the method from the list of HTTP methods in C headers to prevent confusion and breakage of `body-parser`. PR-URL: nodejs/llhttp#105 Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRI gets special treatment (parse preamble and error) and even though it
is parsed and allowed after
HTTP/1.x- it is not technically a methodthat could appear in the request parsed with llhttp. Remove the method
from the list of HTTP methods in C headers to prevent confusion and
breakage of
body-parser.See: #103 (comment)
C header changes
cc @nodejs/http