Skip to content

Conversation

timfish
Copy link
Contributor

@timfish timfish commented Jun 1, 2024

In #88 I added a named Hook export but forgot to update the TypeScript types!

@AbhiPrasad
Copy link
Contributor

Would be nice to get a TS e2e test!

@bengl bengl merged commit c87090d into nodejs:main Jun 14, 2024
@timfish timfish deleted the fix/types branch June 15, 2024 11:49
@tlhunter tlhunter mentioned this pull request Jun 18, 2024
tlhunter added a commit that referenced this pull request Jun 18, 2024
$ git log --oneline --no-decorate v1.8.0..HEAD
a3497a9 v1.8.1
88605a7 fix: Fallback to `parentLoad` if parsing fails (#104)
1c6f7b0 fix: Explicitly named exports should be exported over `export *` (#103)
29f51f6 fix: CommonJs bare specifier resolution (#96)
a8b39f7 fix: `parentResolve` is not a function (#100)
c87090d fix: Named export `Hook` missing from types (#92)
@github-actions github-actions bot mentioned this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants