fix: warning from use of context.importAssertions #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A warning is printed when using context.importAssertions instead of context.importAttributes since Node.js v21.0.0, v20.10.0 and v18.19.0.
|
@timfish Thoughts on this? CI failure is unrelated |
|
What makes you think the CI failures are unrelated? I just re-ran them and they still fail. |
|
@timfish The same failure has been happening in the main branch starting since CI #1498. Something to do with the openai module: |
|
Ah, well we need to fix this before we can merge any PRs because it's stopping the complete test suite from running! |
|
Issue seems to have been introduced with openai v4.85.0 |
timfish
approved these changes
Feb 28, 2025
jsumners-nr
approved these changes
Feb 28, 2025
Merged
mydea
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
May 12, 2025
See https://github.com/nodejs/import-in-the-middle/releases/tag/import-in-the-middle-v1.13.1 ### Bug Fixes * handling of circular dependencies ([#181](nodejs/import-in-the-middle#181)) ([b58092e](nodejs/import-in-the-middle@b58092e)) * importing JSON files ([#182](nodejs/import-in-the-middle#182)) ([8c52014](nodejs/import-in-the-middle@8c52014)) * warning from use of context.importAssertions ([#179](nodejs/import-in-the-middle#179)) ([8e56cf1](nodejs/import-in-the-middle@8e56cf1))
mydea
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
May 12, 2025
See https://github.com/nodejs/import-in-the-middle/releases/tag/import-in-the-middle-v1.13.1 ### Bug Fixes * handling of circular dependencies ([#181](nodejs/import-in-the-middle#181)) ([b58092e](nodejs/import-in-the-middle@b58092e)) * importing JSON files ([#182](nodejs/import-in-the-middle#182)) ([8c52014](nodejs/import-in-the-middle@8c52014)) * warning from use of context.importAssertions ([#179](nodejs/import-in-the-middle#179)) ([8e56cf1](nodejs/import-in-the-middle@8e56cf1)) This version is already allowed by our range, but in order to ensure everybody gets this, bumping it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A warning is printed when using context.importAssertions instead of context.importAttributes since Node.js v21.0.0, v20.10.0 and v18.19.0.
Fixes #172