Skip to content

Conversation

@targos
Copy link
Member

@targos targos commented Oct 16, 2020

Because we used branches with names like release-vx.y.z for previous releases, the action should work correctly as soon as we merge this and open a release PR for the latest fix.
I adapted the changelog to the format used by release-please.

Copy link
Contributor

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryzokuken ryzokuken merged commit 0e5d82f into nodejs:master Oct 16, 2020
@targos targos deleted the release-please branch October 16, 2020 17:29
@bcoe
Copy link

bcoe commented Oct 21, 2020

@targos awesome to see you using release-please 😄

Let me know if you bump into any issues.

@targos
Copy link
Member Author

targos commented Oct 21, 2020

@bcoe release-please is awesome, I'm now using it in many repositories. If I had to mention one issue: the action doesn't have a v2 tag, which means that if a bug is fixed, I have to update all my workflows to the new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants