fix: add support of utf8 encoding #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this fix is needed for node-gyp/lib/find-python to work properly with paths, which contain non-ASCII chars
|
@cclauss hi) pls review my changes. they should be exact same as in my PR to node-gyp in gyp part. thanks in advance |
cclauss
approved these changes
Apr 15, 2021
targos
reviewed
Apr 16, 2021
|
@targos will be this PR merged soon? |
|
I'm not able to review this, sorry. |
|
Who i can ask for review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fix is needed for node-gyp/lib/find-python.js to
work properly with paths, which contain non-ASCII chars
see nodejs/node-gyp#2254 for more info