Find commit by PR when polling Travis builds #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -129,7 +63,9 @@ function pollTravisBuildBySha (options, checkNumber) { | |||
| return console.error(`! ${prInfo} Got error when retrieving Travis builds`, err.stack) | |||
| } | |||
|
|
|||
| const matchingCommit = res.commits.find((commit) => commit.sha === shaToMatch) | |||
| const matchingCommit = res.commits.find((commit) => { | |||
| return commit.sha === shaToMatch || commit.pull_request_number === prToMatch | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Tested with a branch from the main repo nodejs/nodejs.org#490. We need a test PR from a nodejs.org fork as well. |
|
See nodejs/nodejs.org#647 (comment) -- this sometimes incorrectly gets outdated builds |
|
Hmm, looks like it's working now. Strange. |
|
@phillipj might as well merge for now? |
|
@Fishrock123 sure enough |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been struggling with PR builds being triggered with commit SHA we have no reference of - seems like some kind of meta merge commit made by GitHub. Therefore our effort of matching builds by the actual commit SHA from PRs doesn't always work.
There's a trivial change included here in 05af2ed which also tries to match commits by their related PR. Fingers crossed this is what we need.
P.S. this is currently deployed to production.