Skip to content

Node core auto labeling improvements #31

@phillipj

Description

@phillipj

Low hanging fruits

  • doc/ for doc
  • benchmark/ for benchmark
  • deps/$name -> $name (libuv, v8, etc)
  • configure, *Makefile, node.gyp, common.gypi -> build (a lot of stuff in tools/ lives here too but not necessarily low hanging fruit)

To avoid duplicate work on these, please leave a comment if you'd like to give some of these a shot.

Challenges

Regarding the c++ label for any PR that has file changes in src/:

For example, there might be a PR that makes changes to both lib/net.js and src/tcp_wrap.cc, but the overall net change in lib/net.js is substantially greater than that of src/tcp_wrap.cc. In that particular case I would normally just tag it with net only.

How to work on this

Its current labels brain is located in lib/node-labels.js#resolveLabels(). It's even covered by tests test/node-labels.test.js.

Refs nodejs/node#6247

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions