Change Yarn installation method to use tarball #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
This looks pretty good to me! |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
LGTM. Switching to the tarball and using it consistently makes sense. |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Does anyone wish to propose an alternative PR, e.g. one which uses DEB when possible (ref #351)? Or should we go ahead and merge this? |
|
Let's go ahead with this. If at some point there are official Alpine packages, then I think that would be a good time to revisit switching to using packages to install node. |
|
Merged. Thanks everyone. |
ledermann
added a commit
to ledermann/docker-base
that referenced
this pull request
May 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #401
The provided Yarn tarball is now used, instead of the bare webpacked .js file. The tarball is unpacked in
/opt/yarnand the necessary symlinks are created in/usr/local/bin. Installation procedure is the same across all image variants (including Alpine).Users wishing to upgrade Yarn themselves can easily achieve that by deleting the contents of
/opt/yarnand unpacking a more recent tarball there.The size increase is negligible (less than 0.1 MB).