chore: Simplify yarn and alpine version update #2258
+3
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
Before commit 3f6cb08 (fix: only update yarn if there are other changes to the dockerfile), yarnVersion depended on SKIP, so the substitute that followed made sense. This commit removed the condition and changed it to just substitute the version with itself, which doesn't make much sense. Just remove it, and also move the real replace inside SKIP condition. Also postpone retrieving the version to where it is used, and remove the initial assignment to alpine_version, which is never used.
orgads
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR streamlines the Dockerfile update script by removing redundant initial fetches of Alpine and Yarn versions and relocating the Yarn version lookup so it's only performed when updates are desired.
- Eliminated the early assignment of
alpine_versionand initial Yarn version fetch - Removed rewriting the Dockerfile with its own current Yarn version
- Moved the real Yarn version fetch and substitution inside the SKIP check
Comments suppressed due to low confidence (1)
| # Get the currently used Yarn version | ||
| yarnVersion="$(grep "ENV YARN_VERSION" "${dockerfile}" | cut -d' ' -f3)" | ||
| if [ "${SKIP}" != true ]; then | ||
| yarnVersion="$(curl -sSL --compressed https://yarnpkg.com/latest-version)" |
There was a problem hiding this comment.
Fetching the latest Yarn version inside the per-Dockerfile loop will perform a network request for each file. Consider fetching yarnVersion once before looping to reduce redundant network calls.
Suggested change
| yarnVersion="$(curl -sSL --compressed https://yarnpkg.com/latest-version)" |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Good point actually :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before commit 3f6cb08 (fix: only update yarn if there are other changes to the dockerfile), yarnVersion depended on SKIP, so the substitute that followed made sense. This commit removed the condition and changed it to just substitute the version with itself, which doesn't make much sense.
Just remove it, and also move the real replace inside SKIP condition.
Motivation and Context
Testing Details
Tested yarn update.
Example Output(if appropriate)
Types of changes
Checklist