Skip to content

Remove stray * for linux*-s390x in slim images #2257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion 20/bookworm-slim/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@
RUN groupadd --gid 1000 node \
&& useradd --uid 1000 --gid node --shell /bin/bash --create-home node

ENV NODE_VERSION 20.19.3

Check warning on line 6 in 20/bookworm-slim/Dockerfile

View workflow job for this annotation

GitHub Actions / build (20.19.3, bookworm-slim)

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \
&& case "${dpkgArch##*-}" in \
amd64) ARCH='x64' OPENSSL_ARCH='linux-x86_64';; \
ppc64el) ARCH='ppc64le' OPENSSL_ARCH='linux-ppc64le';; \
s390x) ARCH='s390x' OPENSSL_ARCH='linux*-s390x';; \
s390x) ARCH='s390x' OPENSSL_ARCH='linux-s390x';; \
arm64) ARCH='arm64' OPENSSL_ARCH='linux-aarch64';; \
armhf) ARCH='armv7l' OPENSSL_ARCH='linux-armv4';; \
i386) ARCH='x86' OPENSSL_ARCH='linux-elf';; \
Expand Down Expand Up @@ -60,7 +60,7 @@
&& npm --version \
&& rm -rf /tmp/*

ENV YARN_VERSION 1.22.22

Check warning on line 63 in 20/bookworm-slim/Dockerfile

View workflow job for this annotation

GitHub Actions / build (20.19.3, bookworm-slim)

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

RUN set -ex \
&& savedAptMark="$(apt-mark showmanual)" \
Expand Down
2 changes: 1 addition & 1 deletion 20/bullseye-slim/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@
RUN groupadd --gid 1000 node \
&& useradd --uid 1000 --gid node --shell /bin/bash --create-home node

ENV NODE_VERSION 20.19.3

Check warning on line 6 in 20/bullseye-slim/Dockerfile

View workflow job for this annotation

GitHub Actions / build (20.19.3, bullseye-slim)

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \
&& case "${dpkgArch##*-}" in \
amd64) ARCH='x64' OPENSSL_ARCH='linux-x86_64';; \
ppc64el) ARCH='ppc64le' OPENSSL_ARCH='linux-ppc64le';; \
s390x) ARCH='s390x' OPENSSL_ARCH='linux*-s390x';; \
s390x) ARCH='s390x' OPENSSL_ARCH='linux-s390x';; \
arm64) ARCH='arm64' OPENSSL_ARCH='linux-aarch64';; \
armhf) ARCH='armv7l' OPENSSL_ARCH='linux-armv4';; \
i386) ARCH='x86' OPENSSL_ARCH='linux-elf';; \
Expand Down Expand Up @@ -60,7 +60,7 @@
&& npm --version \
&& rm -rf /tmp/*

ENV YARN_VERSION 1.22.22

Check warning on line 63 in 20/bullseye-slim/Dockerfile

View workflow job for this annotation

GitHub Actions / build (20.19.3, bullseye-slim)

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

RUN set -ex \
&& savedAptMark="$(apt-mark showmanual)" \
Expand Down
2 changes: 1 addition & 1 deletion 22/bookworm-slim/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@
RUN groupadd --gid 1000 node \
&& useradd --uid 1000 --gid node --shell /bin/bash --create-home node

ENV NODE_VERSION 22.17.0

Check warning on line 6 in 22/bookworm-slim/Dockerfile

View workflow job for this annotation

GitHub Actions / build (22.17.0, bookworm-slim)

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \
&& case "${dpkgArch##*-}" in \
amd64) ARCH='x64' OPENSSL_ARCH='linux-x86_64';; \
ppc64el) ARCH='ppc64le' OPENSSL_ARCH='linux-ppc64le';; \
s390x) ARCH='s390x' OPENSSL_ARCH='linux*-s390x';; \
s390x) ARCH='s390x' OPENSSL_ARCH='linux-s390x';; \
arm64) ARCH='arm64' OPENSSL_ARCH='linux-aarch64';; \
armhf) ARCH='armv7l' OPENSSL_ARCH='linux-armv4';; \
i386) ARCH='x86' OPENSSL_ARCH='linux-elf';; \
Expand Down Expand Up @@ -60,7 +60,7 @@
&& npm --version \
&& rm -rf /tmp/*

ENV YARN_VERSION 1.22.22

Check warning on line 63 in 22/bookworm-slim/Dockerfile

View workflow job for this annotation

GitHub Actions / build (22.17.0, bookworm-slim)

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

RUN set -ex \
&& savedAptMark="$(apt-mark showmanual)" \
Expand Down
2 changes: 1 addition & 1 deletion 22/bullseye-slim/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@
RUN groupadd --gid 1000 node \
&& useradd --uid 1000 --gid node --shell /bin/bash --create-home node

ENV NODE_VERSION 22.17.0

Check warning on line 6 in 22/bullseye-slim/Dockerfile

View workflow job for this annotation

GitHub Actions / build (22.17.0, bullseye-slim)

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \
&& case "${dpkgArch##*-}" in \
amd64) ARCH='x64' OPENSSL_ARCH='linux-x86_64';; \
ppc64el) ARCH='ppc64le' OPENSSL_ARCH='linux-ppc64le';; \
s390x) ARCH='s390x' OPENSSL_ARCH='linux*-s390x';; \
s390x) ARCH='s390x' OPENSSL_ARCH='linux-s390x';; \
arm64) ARCH='arm64' OPENSSL_ARCH='linux-aarch64';; \
armhf) ARCH='armv7l' OPENSSL_ARCH='linux-armv4';; \
i386) ARCH='x86' OPENSSL_ARCH='linux-elf';; \
Expand Down Expand Up @@ -60,7 +60,7 @@
&& npm --version \
&& rm -rf /tmp/*

ENV YARN_VERSION 1.22.22

Check warning on line 63 in 22/bullseye-slim/Dockerfile

View workflow job for this annotation

GitHub Actions / build (22.17.0, bullseye-slim)

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

RUN set -ex \
&& savedAptMark="$(apt-mark showmanual)" \
Expand Down
2 changes: 1 addition & 1 deletion 24/bookworm-slim/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@
RUN groupadd --gid 1000 node \
&& useradd --uid 1000 --gid node --shell /bin/bash --create-home node

ENV NODE_VERSION 24.4.0

Check warning on line 6 in 24/bookworm-slim/Dockerfile

View workflow job for this annotation

GitHub Actions / build (24.4.0, bookworm-slim)

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \
&& case "${dpkgArch##*-}" in \
amd64) ARCH='x64' OPENSSL_ARCH='linux-x86_64';; \
ppc64el) ARCH='ppc64le' OPENSSL_ARCH='linux-ppc64le';; \
s390x) ARCH='s390x' OPENSSL_ARCH='linux*-s390x';; \
s390x) ARCH='s390x' OPENSSL_ARCH='linux-s390x';; \
arm64) ARCH='arm64' OPENSSL_ARCH='linux-aarch64';; \
armhf) ARCH='armv7l' OPENSSL_ARCH='linux-armv4';; \
i386) ARCH='x86' OPENSSL_ARCH='linux-elf';; \
Expand Down Expand Up @@ -60,7 +60,7 @@
&& npm --version \
&& rm -rf /tmp/*

ENV YARN_VERSION 1.22.22

Check warning on line 63 in 24/bookworm-slim/Dockerfile

View workflow job for this annotation

GitHub Actions / build (24.4.0, bookworm-slim)

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

RUN set -ex \
&& savedAptMark="$(apt-mark showmanual)" \
Expand Down
2 changes: 1 addition & 1 deletion 24/bullseye-slim/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@
RUN groupadd --gid 1000 node \
&& useradd --uid 1000 --gid node --shell /bin/bash --create-home node

ENV NODE_VERSION 24.4.0

Check warning on line 6 in 24/bullseye-slim/Dockerfile

View workflow job for this annotation

GitHub Actions / build (24.4.0, bullseye-slim)

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \
&& case "${dpkgArch##*-}" in \
amd64) ARCH='x64' OPENSSL_ARCH='linux-x86_64';; \
ppc64el) ARCH='ppc64le' OPENSSL_ARCH='linux-ppc64le';; \
s390x) ARCH='s390x' OPENSSL_ARCH='linux*-s390x';; \
s390x) ARCH='s390x' OPENSSL_ARCH='linux-s390x';; \
arm64) ARCH='arm64' OPENSSL_ARCH='linux-aarch64';; \
armhf) ARCH='armv7l' OPENSSL_ARCH='linux-armv4';; \
i386) ARCH='x86' OPENSSL_ARCH='linux-elf';; \
Expand Down Expand Up @@ -60,7 +60,7 @@
&& npm --version \
&& rm -rf /tmp/*

ENV YARN_VERSION 1.22.22

Check warning on line 63 in 24/bullseye-slim/Dockerfile

View workflow job for this annotation

GitHub Actions / build (24.4.0, bullseye-slim)

Legacy key/value format with whitespace separator should not be used

LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format More info: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/

RUN set -ex \
&& savedAptMark="$(apt-mark showmanual)" \
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile-slim.template
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ RUN ARCH= OPENSSL_ARCH= && dpkgArch="$(dpkg --print-architecture)" \
&& case "${dpkgArch##*-}" in \
amd64) ARCH='x64' OPENSSL_ARCH='linux-x86_64';; \
ppc64el) ARCH='ppc64le' OPENSSL_ARCH='linux-ppc64le';; \
s390x) ARCH='s390x' OPENSSL_ARCH='linux*-s390x';; \
s390x) ARCH='s390x' OPENSSL_ARCH='linux-s390x';; \
arm64) ARCH='arm64' OPENSSL_ARCH='linux-aarch64';; \
armhf) ARCH='armv7l' OPENSSL_ARCH='linux-armv4';; \
i386) ARCH='x86' OPENSSL_ARCH='linux-elf';; \
Expand Down