-
Notifications
You must be signed in to change notification settings - Fork 2k
Add Alpine 3.18 variant #1895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add Alpine 3.18 variant #1895
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
bashbrew-arch variants | ||
amd64 alpine3.16,alpine3.17,bullseye,bullseye-slim,buster,buster-slim | ||
arm32v6 alpine3.16,alpine3.17 | ||
arm32v7 alpine3.16,alpine3.17,bullseye,bullseye-slim,buster,buster-slim | ||
arm64v8 alpine3.16,alpine3.17,bullseye,bullseye-slim,buster,buster-slim | ||
i386 alpine3.16,alpine3.17 | ||
ppc64le alpine3.16,alpine3.17,bullseye,bullseye-slim,buster,buster-slim | ||
s390x alpine3.16,alpine3.17,bullseye,bullseye-slim,buster,buster-slim | ||
amd64 alpine3.17,alpine3.18,bullseye,bullseye-slim,buster,buster-slim | ||
arm32v6 alpine3.17,alpine3.18 | ||
arm32v7 alpine3.17,alpine3.18,bullseye,bullseye-slim,buster,buster-slim | ||
arm64v8 alpine3.17,alpine3.18,bullseye,bullseye-slim,buster,buster-slim | ||
i386 alpine3.17,alpine3.18 | ||
ppc64le alpine3.17,alpine3.18,bullseye,bullseye-slim,buster,buster-slim | ||
s390x alpine3.17,alpine3.18,bullseye,bullseye-slim,buster,buster-slim |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
baseuri https://nodejs.org/dist | ||
default_variant bullseye | ||
alpine_version 3.17 | ||
alpine_version 3.18 | ||
debian_versions stretch bullseye buster |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor, but maybe this should move with the rest of the cleanups at line 69
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I wasn't sure about the best location and chose to follow the PHP-approach; this includes a manual
gpgconf --kill all
which I'm not sure is necessary (i.e. it works fine on my end without it, but maybe it has a more specific purpose) which can only be run whengpg
is still installed. So in that case, I could only move it down to be just above theapk del
call. If you prefer that, let me know and I'll update it!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On
gpgconf --kill all
specifically, removing theGNUPGHOME
directory will often fail with race conditions around some of the socket files that end up in there, and we've found that explicitly requesting that GnuPG kill all background daemons first helps with those race conditions (it doesn't completely eliminate them, but it does significantly lessen them).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nschonni as mentioned, if we keep the
gpgconf --kill all
call, this can only be moved as far down as just above line 66. Do you still prefer this, or shall we keep it the current way?Alternatively, we could just merge this for now, as it is functionally equivalent, move the discussion to #1901 and find a definitive approach there.