Skip to content

Add images for debian bookworm #1881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2023
Merged

Add images for debian bookworm #1881

merged 1 commit into from
Jun 11, 2023

Conversation

orgads
Copy link
Contributor

@orgads orgads commented Apr 18, 2023

Description

Bookworm should be released soon, add it to debian variants.

Types of changes

  • Documentation
  • Version change (Update, remove or add more Node.js versions)
  • Variant change (Update, remove or add more variants, or versions of variants)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Others (non of above)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • All new and existing tests passed.

@nschonni
Copy link
Member

Thanks, but it looks like it's not stable yet, and doesn't have a release date set https://www.debian.org/releases/

@nschonni nschonni closed this Apr 18, 2023
@nschonni nschonni reopened this Apr 18, 2023
@nschonni nschonni marked this pull request as draft April 18, 2023 07:14
@nschonni
Copy link
Member

Flipped this to draft, as it looks good for when bookworm is stable. I'm guessing Node 14 might hit EOL at the end of the month before this might go live

@reactuz
Copy link

reactuz commented Apr 19, 2023

@nschonni We also need this on our project, as bookworm offers OpenSSL 3, which is the default version that Node has been using in latest LTS version. We are tied to discrepancies in versions of OpenSSL provided by Node 17.x+ (3.0.7) and by Debian 11 (1.1.1). Resolution of this issue could help us upgrade to latest LTS version of Node.

@orgads
Copy link
Contributor Author

orgads commented May 16, 2023

The planned release date is June 10 (in less than a month).

@HeyITGuyFixIt
Copy link

It appears that this is missing bookworm images for node:20.

Also, while trying to test these images, I get an error while bringing up a container that says Error response from daemon: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "docker-entrypoint.sh": executable file not found in $PATH: unknown. Not sure if I did something wrong or what's going on with that. Maybe /usr/local/bin/ isn't in the path in bookworm?

@orgads orgads force-pushed the bookworm branch 3 times, most recently from 39981bd to 9569c34 Compare May 18, 2023 19:05
@orgads
Copy link
Contributor Author

orgads commented May 18, 2023

@HeyITGuyFixIt Thanks a lot for reviewing and testing. Both issues are fixed now. The entrypoint scripts were missing executable bit.

@nschonni nschonni linked an issue Jun 11, 2023 that may be closed by this pull request
@nschonni
Copy link
Member

@orgads now that bookworm has been released, would you like to rebase this so it can be landed?

@orgads orgads marked this pull request as ready for review June 11, 2023 06:36
@orgads
Copy link
Contributor Author

orgads commented Jun 11, 2023

Done, and changed it to be the default.

@orgads orgads force-pushed the bookworm branch 2 times, most recently from 71ea0a1 to e59e2c5 Compare June 11, 2023 06:39
@nschonni nschonni merged commit 6163be1 into nodejs:main Jun 11, 2023
@github-actions
Copy link

Created PR on the official-images repo (docker-library/official-images#14822). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debian 12 "bookworm"
4 participants