Added an entrypoint script #1043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaurentGoderre
force-pushed
the
entrypoint
branch
from
da595e4 to
98579fb
Compare
tianon
reviewed
May 23, 2019
10/jessie/Dockerfile
Outdated
| @@ -61,4 +61,8 @@ RUN set -ex \ | |||
| && ln -s /opt/yarn-v$YARN_VERSION/bin/yarnpkg /usr/local/bin/yarnpkg \ | |||
| && rm yarn-v$YARN_VERSION.tar.gz.asc yarn-v$YARN_VERSION.tar.gz | |||
|
|
|||
| COPY docker-entrypoint.sh /usr/local/bin/ | |||
| RUN ln -s usr/local/bin/docker-entrypoint.sh / # backwards compat | |||
There was a problem hiding this comment.
You've never had an entrypoint before so this symlink is unnecessary.
There was a problem hiding this comment.
AAh, I wasn't sure if it was compatibility with older versions of docker. Good to know!
LaurentGoderre
force-pushed
the
entrypoint
branch
2 times, most recently
from
f2032c3 to
b3052a9
Compare
LaurentGoderre
force-pushed
the
entrypoint
branch
from
b3052a9 to
7e47b37
Compare
|
@PeterDaveHello @chorrell any issue with this? |
|
LGTM. |
chorrell
approved these changes
May 30, 2019
|
Created PR to the official-images repo (docker-library/official-images#6021) |
|
For others who were relying on the old behavior with the implicit ENTRYPOINT [] |
|
@sloria yikes sorry. I didn't know about that use case. |
|
Making breaking changes to docker images between 10.15 and 10.16 seems a bit wrong. This hit us, @sloria's suggestion will help (as would changing CMD to remove node) but it still feels wrong. |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1039