Repository navigation
PRs updates may cause unwanted PR creation in docker-library/official-images #2564
Description
Activity
There probably some kind of linter enforcing this. The CI should also be updated to run
./update.shso CI result stays relevantThe main issue seems to be the automatic trigger of .github/workflows/official-pr.yml
docker-node/.github/workflows/official-pr.yml
Lines 3 to 13 in f2f2bf1
which can cause a PR to be created for a new release, when this is not wanted. For example in PR #2494 which cleans up the architectures used without actually removing any actively used architectures.
A way to handle this flexibly would be to add a new label such as
skip-releaseto be applied by a maintainer (user with write access to repo) to a PR before merge, if the PR contains updated Dockerfiles that do not need a new release. .github/workflows/official-pr.yml could check for the presence of that label and skip running if that label is set.
Situation
When
Dockerfile-template.*changes are made andDockerfileupdates in the release line directories are also made, then the repo automatically triggers a PR to build a new release. The workflow official-pr is responsible for this.Unless the update is part of a new release, then
Dockerfileupdates should generally not be done manually. These updates should be left to the automated processes that are triggered when the repo's automatic-updates.yml polling workflow detects a new Node.js release.Suggestion
Research the background and add instructions to the CONTRIBUTING document about when
Dockerfileupdates should be made directly, and when it should be left to automation.For those cases where no direct
Dockerfileupdate should be included in a PR, describe also how to test such PRs.