Skip to content

hotfix: de-require dry_run#199

Merged
ovflowd merged 3 commits intonodejs:mainfrom
avivkeller:patch-3
Oct 28, 2025
Merged

hotfix: de-require dry_run#199
ovflowd merged 3 commits intonodejs:mainfrom
avivkeller:patch-3

Conversation

@avivkeller
Copy link
Member

cc @ovflowd. GitHub action is really annoying! Sorry for the issues 😓

Removed 'required' property from 'dry_run' input.
Copilot AI review requested due to automatic review settings October 27, 2025 21:45
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the required: true constraint from the dry_run workflow input parameter in the manual meeting artifacts creation workflow. This change makes the dry_run parameter optional while maintaining its boolean type and default value of false.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@avivkeller avivkeller marked this pull request as draft October 27, 2025 21:47
@avivkeller avivkeller marked this pull request as ready for review October 27, 2025 21:50
Copilot AI review requested due to automatic review settings October 27, 2025 21:50
@avivkeller
Copy link
Member Author

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ovflowd ovflowd merged commit b63f33d into nodejs:main Oct 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants