feat(cicd,scripts): rely on npx over npm#195
Merged
ovflowd merged 2 commits intonodejs:mainfrom Oct 23, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR transitions the tool from using npm scripts to npx-based execution, enabling users to run the tool directly via npx commands without requiring predefined npm scripts. The binary name is also updated from create-meeting to create-node-meeting-artifacts for consistency.
- Renamed the binary entry point to match the package name
- Removed all meeting-specific npm scripts (45+ script entries)
- Updated documentation to reflect npx usage patterns
- Refactored GitHub Actions workflow to dynamically discover meeting groups
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| package.json | Updated binary name and removed meeting-specific scripts and test coverage script |
| README.md | Removed meeting commands table and updated local development examples to use npx |
| .github/workflows/create-meeting-artifacts-scheduled.yml | Replaced hardcoded meeting matrix with dynamic discovery from template files |
| .github/workflows/create-meeting-artifacts-manual.yml | Changed meeting_group from choice to string input and added workflow_call trigger |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
Author
|
Let's land this :-) |
Member
|
Do I get a cookie if I land this? |
Member
Author
🍪 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the tool from using
npmscripts to usenpxscripts. This means that the following commands can be used, instead ofnpm run [...]: