feat: updated, refactored and cleaned up #180
Open
+1,276
−205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it would be good to get the updated version working/tested in real life before landing changes to the repo. I won't have time to debug if changes break the live tooling which regularly updates from this repo to pull in changes. |
+1. I haven't tested this for real yet, so we shouldn't land before I'm able to confirm it works fine. Would unit testing also make sense here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the usage of very old dependencies for the ones maintained officially by Google with updated APIs.
This PR refactors and modularizes the source code and ensures it is functional via environmnent-based configuration, instead of fie-system ones.
It also amplifies the code, documentation and ensures it is easy to contribute towards.