grab-module-data: fix broken test #928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npm 7 and higher now have an exit code for failed fetches. This introduces a subtle behavior change in testing as the error cases are slightly different. This tiny change to `grab-module-data.js` adds a regex to ensure a consistent code path is followed across all maintained versions of npm. TBH there is likely a cleaner way to fix this, but it would involve a lot more refactoring which could create other unexpected bugs.
MylesBorins
force-pushed
the
fix-broken-test
branch
from
dc830c4 to
4863352
Compare
|
It looks like windows CI on 16 is still failing, but it is unrelated to the test that has currently been broken on all platforms. So I think we should consider landing this as an iterative change to fix broken CI while we figure out what is going on with windows |
targos
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm 7 and higher now have an exit code for failed fetches. This introduces a subtle behavior change in testing as the error cases are slightly different. This tiny change to
grab-module-data.jsadds a regex to ensure a consistent code path is followed across all maintained versions of npm.TBH there is likely a cleaner way to fix this, but it would involve a lot more refactoring which could create other unexpected bugs.
This should fix the broken CITGM test suite