Repository navigation
test: fix npm test compatibility with v27 nightly - #1188
Open
MikeMcC399 wants to merge 2 commits into
Open
MikeMcC399 wants to merge 2 commits into
MikeMcC399 wants to merge 2 commits into
Conversation
changed for npm 12 compatibility which otherwise throws an error for unknown cli flags Signed-off-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
changed for npm 12 compatibility which otherwise throws an error EALLOWGIT when attempting to install from a git source Signed-off-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1188 +/- ##
==========================================
- Coverage 96.20% 96.11% -0.10%
==========================================
Files 29 29
Lines 2213 2213
==========================================
- Hits 2129 2127 -2
- Misses 84 86 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
MikeMcC399
marked this pull request as ready for review
October 8, 2026 16:33
This was referenced Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm run tap(2 failures) #1130Situation
Running
npm testfails under Node.js v27 nightlies, which now includenpm@12.1.0.Change
Add the environment variable
npm_config_allow_git: 'all'to the test "citgm: omg-i-pass from git url" in test/test-citgm.js.Replace the parameter
--extra-paramwith the environment variablenpm_config_extra_paraminstead of passing it using the CLI. See https://docs.npmjs.com/cli/v12/using-npm/config#environment-variablesVerification
On Ubuntu 26.04.1 LTS, with n Node.js version manager installed.
Confirm successful test.
Checklist
npm testpasseshere