Skip to content

Commit

Permalink
ci: update GitHub actions workflow (#805)
Browse files Browse the repository at this point in the history
- Use Node.js 14 in actions/setup-node

- Add Node.js 14.x to the test matrix

- Remove CI: true from the environment

The variable is already set by GitHub

- Fix bug in test fixture

Discovered with v14.x because of
nodejs/node#31030.
  • Loading branch information
targos authored May 2, 2020
1 parent 0979a96 commit a67edc7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
8 changes: 3 additions & 5 deletions .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Use Node.js 13
- name: Use Node.js 14
uses: actions/setup-node@v1
with:
node-version: 13
node-version: 14.x
- name: npm install and lint
run: |
npm install
Expand All @@ -26,7 +26,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [10.x, 12.x, 13.x]
node-version: [10.x, 12.x, 13.x, 14.x]
os: [ubuntu-latest, windows-latest, macOS-latest]
runs-on: ${{ matrix.os }}
steps:
Expand All @@ -40,7 +40,5 @@ jobs:
run: |
npm install
npm run tap -- --coverage-report=lcov
env:
CI: true
- name: Upload coverage report to Codecov
uses: codecov/codecov-action@v1
2 changes: 1 addition & 1 deletion test/fixtures/omg-i-write-to-tmpdir/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ const { join } = require('path');
const { tmpdir } = require('os');
const { writeFileSync } = require('fs');

writeFileSync(join(tmpdir(), 'omg-i-write-to-tmpdir-testfile'));
writeFileSync(join(tmpdir(), 'omg-i-write-to-tmpdir-testfile'), '');

0 comments on commit a67edc7

Please sign in to comment.