jenkins: relax check for trusted nodejs/node branches#4052
Merged
richardlau merged 1 commit intomainfrom Mar 27, 2025
Merged
Conversation
Only enforce the COMMIT_SHA_CHECK verification when: - The org/repo is not nodejs/node (i.e. outside of our project). - The org/repo is nodejs/node and the reference is for a pull request.
targos
approved these changes
Mar 27, 2025
BridgeAR
approved these changes
Mar 27, 2025
UlisesGascon
approved these changes
Mar 27, 2025
Member
UlisesGascon
left a comment
UlisesGascon
left a comment
There was a problem hiding this comment.
LGTM! Thanks for this big effort @richardlau ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only enforce the COMMIT_SHA_CHECK verification when:
Refs: #4046
This relaxes the check added in #4046 to not apply for https://github.com/nodejs/node references that are not pull request references. This will reallow scheduled builds (e.g. daily test builds of
mainand the staging branches).For pull request references, or requests to build references from other repositories, the check will still be enforced.