ansible: add ClangCL to VS2022#3714
Merged
StefanStojanovic merged 1 commit intonodejs:mainfrom May 11, 2024
Merged
Conversation
This is a part of an effort to enable compilation with Clang on Windows. This commit enables building with ClangCL in the CI. Fixes: nodejs#3709
targos
approved these changes
May 10, 2024
13 tasks
StefanStojanovic
added a commit
to JaneaSystems/build
that referenced
this pull request
Jun 26, 2024
Adds a missing VS component required for ClangCL compilation Refs: nodejs#3714 Refs: nodejs#3709
StefanStojanovic
added a commit
that referenced
this pull request
Jun 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a part of an effort to enable compilation with Clang on Windows. This commit enables building with ClangCL in the CI.
This change is already applied to all VS2022 machines in the test and release CI. Note, that changing
paramsfor thewin_chocolateydoesn't trigger installing a new component, so I installed these components manually on the existing machines.After everything is ready in the main repo, I'll rework Jenkins jobs and make changes needed to this repo to enable compiling and testing Clang compiled Node.js.
Fixes: #3709