jenkins: handle no matches in download-test.sh #3113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing CI is due to a new version of |
If no matches for `NODE_VERSION` are found, bail out of the script. Previously if no matches were found the following rsync would attempt to download the entire `downloadDir`, e.g., for `release`, every release we've done!
UlisesGascon
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no matches for
NODE_VERSIONare found, bail out of the script. Previously if no matches were found the following rsync would attempt to download the entiredownloadDir, e.g., forrelease, every release we've done!See https://ci.nodejs.org/job/validate-downloads/2011/console which ran out of disk space trying to rsync everything in
releasebecause mirroring from www to unencrypted was broken (due to the IP change for unencrypted -- I've now updated the firewall on www for the unencrypted's new IP address) and the new versions were not mirrored to unencrypted.