Skip to content

fix: Anchored ubuntu version to support Python 2.7 in Github Actions#3086

Merged
UlisesGascon merged 1 commit into
nodejs:mainfrom
UlisesGascon:fix/python2.x-in-github-actions
Nov 22, 2022
Merged

fix: Anchored ubuntu version to support Python 2.7 in Github Actions#3086
UlisesGascon merged 1 commit into
nodejs:mainfrom
UlisesGascon:fix/python2.x-in-github-actions

Conversation

@UlisesGascon
Copy link
Copy Markdown
Member

@UlisesGascon UlisesGascon commented Nov 22, 2022

Main changes

  • Update Github actions runner from ubuntu-latest to ubuntu-20.04

Context

@UlisesGascon UlisesGascon self-assigned this Nov 22, 2022
@UlisesGascon UlisesGascon mentioned this pull request Nov 22, 2022
Merged
@targos
Copy link
Copy Markdown
Member

targos commented Nov 22, 2022

Can we try first with setup-python@v4?

@UlisesGascon UlisesGascon mentioned this pull request Nov 22, 2022
Closed
@UlisesGascon
Copy link
Copy Markdown
Member Author

UlisesGascon commented Nov 22, 2022

@targos I created an alternative version at #3090 by upgrading the actions, but seems like is using the newer ubuntu version under the hood

@targos
Copy link
Copy Markdown
Member

targos commented Nov 22, 2022

Ok, thanks for trying.

@richardlau
Copy link
Copy Markdown
Member

richardlau commented Nov 22, 2022

@targos I created an alternative version at #3090 by upgrading the actions, but seems like is using the newer ubuntu version under the hood

Yes, GH is in the middle of migrating ubuntu-latest to 22.04: actions/runner-images#6399.

We should probably be updating to setup-python@v4 regardless (maybe a separate PR?).

richardlau
richardlau approved these changes Nov 22, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this and fix the workflows.

We might subsequently consider dropping Python 2.7 from the workflow matrix. I think #2659 effectively means you need to be running Python 3 to run our playbooks anyway.

@UlisesGascon
Copy link
Copy Markdown
Member Author

UlisesGascon commented Nov 22, 2022

I will do the merge and then two separate PRs for:

  • Upgrade to setup-python@v4
  • Remove support for Python2

@UlisesGascon UlisesGascon merged commit afeb408 into nodejs:main Nov 22, 2022
This was referenced Nov 22, 2022
Merged
Merged
richardlau added a commit to richardlau/build that referenced this pull request Apr 8, 2025
@richardlau
chore: switch back to ubuntu-latest
dde51fd 
We previously pinned this workflow to `ubuntu-20.04` to preserve Python 2.7 compatibility, but have since dropped Python 2.7 so can now unpin.

Refs: nodejs#3086
Refs: nodejs#3093
Refs: actions/runner-images#11101
@richardlau richardlau mentioned this pull request Apr 8, 2025
Closed
richardlau added a commit that referenced this pull request Apr 8, 2025
@richardlau
chore: switch back to ubuntu-latest
7af06a3 
We previously pinned this workflow to `ubuntu-20.04` to preserve Python 2.7 compatibility, but have since dropped Python 2.7 so can now unpin.

Refs: #3086
Refs: #3093
Refs: actions/runner-images#11101
@richardlau richardlau mentioned this pull request Apr 8, 2025
Merged
richardlau added a commit that referenced this pull request Apr 9, 2025
@richardlau
chore: switch back to ubuntu-latest (#4065)
194e10d 
We previously pinned this workflow to `ubuntu-20.04` to preserve Python 2.7 compatibility, but have since dropped Python 2.7 so can now unpin.

Refs: #3086
Refs: #3093
Refs: actions/runner-images#11101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targos targos targos approved these changes

@richardlau richardlau richardlau approved these changes

Assignees

@UlisesGascon UlisesGascon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@UlisesGascon @targos @richardlau