-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jenkins: add ARM64 Windows #2408
Conversation
That's one nasty hack in the version selector to get the checkbox to work! Probably better than building too much more of the logic into Jenkins but it might not be a good pattern to encourage unless we can find a way to make it a bit cleaner. Is the intention to leave the checkbox only at the fanned-arm64 job and its subjobs or does it get migrated all the way up the job call stack? And what's the path to a more permanent CI presence? Do we have any word on Windows ARM64 hosting options, do we even imagine that possibility on the horizon or are we going to be in a similar position to our Pi cluster, with Windows laptops in offices? |
Only at the
The plan is to have Windows ARM64 VMs on Azure as soon as they become available. There is no set date for that to happen, but we'd like to wait some time in order to avoid the laptops in offices option. |
@joaocgreis What would I need to do to run a local a build of this? Can I just give an |
@sxa Visual Studio needs some optional components installed, listed in https://github.com/nodejs/node/blob/master/BUILDING.md#option-1-manual-install. In that list the first point mentions you need an ARM64 machine but that's not correct (a correction should land soon). At the moment, you can only build from x64. Then, just add |
PR-URL: #2408 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Ash Cripps <ashley.cripps@ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Landed in b03b57c Will update the Jenkins jobs. |
Jenkins jobs updated. Test run: https://ci.nodejs.org/view/All/job/node-test-commit-windows-fanned/37850/ |
@joaocgreis do you have any idea when we'll see Windows arm64 show up in unofficial/nightly builds? Those still seem to be x64 and x86-only: https://nodejs.org/download/nightly/v15.0.0-nightly20200922d71b467bbe/ and https://unofficial-builds.nodejs.org/download/release/v14.11.0/. Please let me know if I can be of any help here 😊 |
PR-URL: #2408 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Ash Cripps <ashley.cripps@ibm.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Windows ARM64 cross-compilation support has recently been added to master/v14. This adds Windows ARM64 to the main Windows compile job in Jenkins. This allows us to move support for compilation for Windows ARM64 to Tier 2.
Running Node.js on ARM64 is still experimental, and we only have one machine connected to Jenkins at the moment. Thus, a checkbox is added in the main job to run the tests, disabled by default.
Test job: https://ci.nodejs.org/view/All/job/node-test-commit-windows-fanned-arm64/ . The changes in this job and the 3 subjobs that have the
-arm64
suffix need to land on the main jobs simultaneously with this PR.cc @nodejs/build @nodejs/platform-windows