ansible: prepare jenkins-workspace machines for linting duty

[rvagg]

Ref: #2001

Also included this is a reprovisioned jenkins-workspace-1, it started having problems 2 weeks back and has locked up twice now. I just made a new one and re-attached the big network block device we're using for /home from the old one so it's good to go.

I've run this against the hosts, I've also switched the label for the linter job in Jenkins from linter to jenkins-workspace so they've already taken over duty from the FreeBSD 10 machines which we need to retire.

The script has changed, a few old bits are removed and the BSD-compatibility is gone too:

#!/bin/bash -ex

# Lint with python3 in new branches
# Refs: https://github.com/nodejs/build/issues/1631
if [[ "$NODEJS_MAJOR_VERSION" -ge "12" ]]; then
  make lint-py-build PYTHON=python3 || true
  make lint-py PYTHON=python3
fi
    
make lint-py-build PYTHON=python2 || true
make lint-ci PYTHON=python2 || { 
  cat test-eslint.tap | grep -v '^ok\|^TAP version 13\|^1\.\.' | sed '/^\s*$/d' && 
  exit 1; }

[cclauss]

LGTM. I am highly supportive of this effort.

[joaocgreis]

There is a "Set up linter servers" section just above this, that runs exclusively on the two hosts being removed here. Shouldn't that section be completely removed? There are some bits about core-validate-commit there that I don't know if are still relevant in some scenario.

[rvagg]

Yeah, missed that, also missed core-validate-commit. There is a job: https://ci.nodejs.org/job/node-test-commitmsg/ that runs it but it hasn't had any runs since the last build cleanup (~1 week). Does that mean it's disabled? Maybe this is all handled happily in Travis now and in node-core-utils. @nodejs/tooling can you weigh in here? Can we remove node-test-commitmsg from Jenkins and the associated server resources for running it?

[richardlau]

We are definitely running core-validate-commit as part of node-core-utils and on Travis for PRs and that should be sufficient for the normal PR workflows for core.

An old issue, #793, proposed adding https://ci.nodejs.org/job/node-test-commitmsg/ to node-test-pull-request but that didn't happen.

[rvagg]

Integrating core-validate-commit into my .ci.yml proposal; a failing v8.x: https://ci.nodejs.org/job/rv-test-commit-linux-docker/129/label=docker-host-x64,linux_x64_container_suite=lint-commit/console, ci.yml entry (see 'tests->lint-commit' block): https://github.com/rvagg/io.js/blob/rvagg/testing-containers-v8.x/.ci.yml

I might archive that Jenkins job since it's not in use, it can be unarchived if there's reason to before it eventually gets deleted.