jenkins: add node-test-commit-pre#1004
jenkins: add node-test-commit-pre#1004maclover7 wants to merge 1 commit intonodejs:masterfrom maclover7:jm-ntc-pre
Conversation
All actions run before pending post-build-status-update job is run. My thought is that node-test-commit sub jobs will `curl` from master, and then pipe to bash.
|
👍 even if we don't |
|
Instead of curl, my first thought would be that we'd clone the build repo at the start of each job and then can run the scripts directly. Either way seems like a good first step for pulling some logic out of the jenkins config and into git where we can more easily track changes. |
All actions run before pending post-build-status-update job is run. My thought is that node-test-commit sub jobs will `curl` from master, and then pipe to bash. PR-URL: #1004 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
|
Landed in 2e05d83 |
|
I rolled the change back for P.S. I was sure |
|
that's because I had some custom work in there for node-test-commit-linux-linked to solve a problem related to status posting, the addition and explanation is shown in this comment: nodejs/node#17151 (comment) I could pull that into a separate script and we'd be back to status quo. Re curl vs git I like the idea of using git cause there's a bunch more things we could pull into it, we could replace most (or all?) of our jenkins scripts with scripts in this repo if we did a clone first. |
All actions run before pending post-build-status-update job is run. My
thought is that node-test-commit sub jobs will
curlfrom master, andthen pipe to bash.