Problems updating CI status for jobs that git rebase

[maclover7]

Take a look at this node-test-commit-arm-fanned build and its corresponding post-build-status-update build. If you pull up the parameters for the post-build-status-update, you can see that COMMIT is ${GIT_COMMIT}, due to the git-rebase job that was run with arm-fanned, clearing the environment variable automatically set by Jenkins.

Biggest problem is that this is causing the wrong CI status to be sent to be GitHub. Related problem (I myself don't have context on this, part of why I'm opening the issue) is why we would need to run git-rebase on certain node-test-commit sub jobs, but not on others :(

cc @MylesBorins, I think this may have been part of what was causing the issue for you in nodejs/node#16848
cc @refack @gibfahn

[joaocgreis]

According to https://wiki.jenkins.io/display/JENKINS/Git+Plugin , it's the git plugin that sets GIT_COMMIT. The *-fanned jobs don't use the git plugin because they don't need to (running it would make them slower). This is why that variable does not exist, not because git-rebase clears it.

The git-rebase job is needed to rabase (which is done by a build step in other jobs) and push the commit to test to the temp repo. This rebase step could be part of the compile jobs, but it would make them more complex than they already are, so I'd prefer not to go that way. What we can do to make this work is add a git checkout in the fanned jobs and accept the delay.

[gibfahn]

Couldn't the node-test-commit job just pass GIT_COMMIT down to the subjobs?

[joaocgreis]

I've added the parameter GIT_COMMIT to both fanned jobs, and logic in node-test-commit to pass it down. Seems to be working as expected, please reopen if not.