Repository navigation
Moving DISTTYPEDIR to CI-Release script for Windows #776
Description
@gibfahn @jbergstroem @rvagg @mhdawson (or anyone else with access to ci-release): can you take a look at https://ci-release.nodejs.org/job/iojs+release/jobConfigHistory/showDiffFiles?timestamp1=2017-06-21_18-30-42×tamp2=2017-06-28_13-11-55 ? I believe the change is right, but it's better to have a review.
It became necessary after nodejs/node#13900 . I believe it is simpler to have DISTTYPEDIR set in the release script, but have no strong feelings about this.
This is currently under test with a nightly: https://ci-release.nodejs.org/job/iojs+release/1797/ (replaces the one that was automatically started and aborted by me, the job was not fixed yet). EDIT: Nightly was correctly published.
Activity
refack commentedon Jun 28, 2017
Ref: nodejs/node#13969
I originally removed it from
vcbuild.batbecause it was set in a redefined subroutine (which seemed strange), and I couldn't find any reference to it in our code base.But is there any chance any downstream consumer still uses it (i.e. NVIDIA, Microsoft, or anyone who builds their own
node.exe)?joaocgreis commentedon Jun 28, 2017
@refack that is possible, any staging server could be used in
vcbuild.bat. But I have no idea, never heard of a concrete case of anyone using our build scripts with their own infra.refack commentedon Jun 28, 2017
http://blog.sec-consult.com/2017/04/application-whitelisting-application.html
NVIDIA build
node.exeand sign it with their own certificate 🤦♂️joaocgreis commentedon Jun 28, 2017
For that they only need to run
vcbuild signin a machine with the certificate installed. Uploading to a staging server goes a bit further 🙂refack commentedon Jun 28, 2017
AFAICT the nightlies have been built (I looked in the
.xzand the newvcbuild.batis there)richardlau commentedon Jun 28, 2017
IBM does to produce https://developer.ibm.com/node/sdk/.
joaocgreis commentedon Jun 28, 2017
@richardlau in case you need to keep your infra in sync, my change above only adds
set DISTTYPEDIR=%DISTTYPE%before callingvcbuild.bat.richardlau commentedon Jun 28, 2017
@joaocgreis I think
DISTTYPEDIRis one of the things we don't use.cc @gibfahn
mhdawson commentedon Jun 29, 2017
@joaocgreis the change in the job likes like the right replacement for what was removed. Having said that I don't quite understand why it was removed from the build script if we need it and other teams that build releases might need it as well.
gibfahn commentedon Jun 29, 2017
For posterity, according to StackOverflow this will only be used for
getnodeversion.It was removed accidentally, and is re-added in nodejs/node#13969.
gibfahn commentedon Jul 3, 2017
Just came across nodejs/node#2084, which seems relevant. @joaocgreis I think your change still makes sense in that context.
joaocgreis commentedon Jul 11, 2017
I believe this can be closed now. Please reopen if there's any issue.