Enable --abort-on-timeout for node-test-commit-smartos Jenkins job

[misterdjules]

nodejs/node#11086 introduced a new --abort-on-timeout command line option for tools/test.py that makes tests that timeout abort instead of being terminated.

I'd like to use this flag for test jobs running on SmartOS so that we can get a core file when a test times out and investigate the cause for the test timing out.

When testing the PR mentioned above, I had already added a new test job named "node-test-commit-smartos-abort-on-timeout" that defines a new environment variable TEST_CI_ARGS and sets it to --abort-on-timeout by default.

What do you think of making the same change to the node-test-commit-smartos job?

/cc @nodejs/build

[gibfahn]

Sounds good to me

[misterdjules]

Modified the node-test-commit-smartos job to add a TEST_CI_ARGS parameter with a default value of --abort-on-timeout, and deleted the test job node-test-commit-smartos-abort-on-timeout that had been used to test this change.

[bnoordhuis]

This is breaking the CI for non-master branches, see e.g. https://ci.nodejs.org/job/node-test-commit-smartos/6865/nodes=smartos14-32/console which is a run of v6.x-staging. If this can't be fixed easily and speedily, it should be rolled back for now.

[bnoordhuis]

To save people from clicking through, the error is this:

test.py: error: no such option: --abort-on-timeout

Which makes sense because nodejs/node#11086 hasn't been back-ported yet.

[misterdjules]

My apologies, I disabled the new flag in node-test-commit-smartos for now, and I'll work on a backport asap. Thank you for investigating, and sorry for the trouble!

[bnoordhuis]

Thanks, Julien.

[thefourtheye]

Is it generally okay to backport, given that it hasn't been released in "Current" release stream?

[misterdjules]

Is it generally okay to backport, given that it hasn't been released in "Current" release stream?

I would think so. Is there any indication of the contrary somewhere? FWIW, this change is part of the v7.6.0 release proposal at nodejs/node#11185.