Just noticed while editing the job config for #1959 that the CITGM job explicitly sets CONFIG_FLAGS to build small-icu:
We've recently made full-icu the default for master and the upcoming 13.x but the above will build Node.js in a non-default mode and probably means the CITGM run for nodejs/node#29522 didn't actually test what we thought it did ☹️.
I'll remove the explicit set after #1959 is resolved (don't want to change multiple things at once).
FYI @nodejs/releasers @nodejs/citgm
Just noticed while editing the job config for #1959 that the CITGM job explicitly sets
CONFIG_FLAGSto buildsmall-icu:We've recently made☹️ .
full-icuthe default formasterand the upcoming13.xbut the above will build Node.js in a non-default mode and probably means the CITGM run for nodejs/node#29522 didn't actually test what we thought it didI'll remove the explicit set after #1959 is resolved (don't want to change multiple things at once).
FYI @nodejs/releasers @nodejs/citgm