Skip to content

Jenkins merge jobs always overwrites PR-URL and Reviewed-By #179

Closed
@orangemocha

Description

@orangemocha

If there is an existing PR-URL or Reviewed-By in a commit message, node-merge-commit/node-accept-pull-request will strip it. This is documented in the wiki though probably not clearly enough:

Note that existing PR-URL: and Reviewed-By: lines in the commit messages will be stripped, and replaced by the ones specified in the form. This only happens when PR-URL or Reviewed-By is found at a beginning of a line. If you want to preserve existing PR-URL: or Reviewed-By: you can simply indent them in your commit messages.

This behavior is not ideal, and it has caused some trouble already. Furthermore, it prevents landing commits with different PR-URL / Reviewed-By metadata in the same job run.

I'd like to come up with a way that also supports the following scenarios:

  1. Preserve existing PR-URL / Reviewed-By and don't add any such fields
  2. In case of backports / forwardports, preserve original metadata but also add new metadata. Indenting the old metadata with a space or > could help distinguish the two.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions