Missing out/Debug/node on test-digitalocean-ubuntu1604_sharedlibs_container-x64-* #1516

Activity

1. joyeecheung commented on Oct 3, 2018

   

   joyeecheung

   on Oct 3, 2018

   MemberAuthor

   More actions

   Also tap2unit doesn't seem to understand the FAIL_MSG output in tap format

   08:23:28 mkdir out/junit
   08:23:28 tap2junit -i test.tap -o out/junit/test.xml
   08:23:28 tap2junit -i cctest.tap -o out/junit/cctest.xml
   08:23:29 [ubuntu1604_sharedlibs_debug_x64] $ /bin/sh -xe /tmp/jenkins2059204694532914135.sh
   08:23:29 + set -x
   08:23:29 + mkdir out/junit
   08:23:29 + tap2junit -i test.tap -o out/junit/test.xml
   08:23:29 Traceback (most recent call last):
   08:23:29   File "/usr/local/bin/tap2junit", line 11, in <module>
   08:23:29     sys.exit(main())
   08:23:29   File "/usr/local/lib/python2.7/dist-packages/tap2junit/__main__.py", line 44, in main
   08:23:29     result = parse(os.path.splitext(args.input.name)[0], data)
   08:23:29   File "/usr/local/lib/python2.7/dist-packages/tap2junit/__main__.py", line 15, in parse
   08:23:29     t = TestCase(test.description, None, test.yaml['duration_ms'])
   
2. refack commented on Oct 3, 2018

   

   refack

   on Oct 3, 2018

   Last edited by refack

   Contributor

   More actions

   (1) is probably a subtle race bug in nodejs/node#23156
   (2) there's a newer version of tap2junit that needs to be deployed to all workers.
   the bug is that the add hoc TAP generator does not specify duration_ms:

   02:23:27 + echo 1..1
   02:23:27 + echo 'not ok 1 No Debug executable'
   02:23:27 + exit -1
   ...
   02:23:29 + tap2junit -i test.tap -o out/junit/test.xml
   02:23:29 Traceback (most recent call last):
   02:23:29   File "/usr/local/bin/tap2junit", line 11, in <module>
   02:23:29     sys.exit(main())
   02:23:29   File "/usr/local/lib/python2.7/dist-packages/tap2junit/__main__.py", line 44, in main
   02:23:29     result = parse(os.path.splitext(args.input.name)[0], data)
   02:23:29   File "/usr/local/lib/python2.7/dist-packages/tap2junit/__main__.py", line 15, in parse
   02:23:29     t = TestCase(test.description, None, test.yaml['duration_ms'])
   02:23:29 TypeError: 'NoneType' object has no attribute '__getitem__'
   

   Fix was to make it non mandatory:
   https://github.com/refack/tap2junit/blob/7d9574915148b488b23be699f2a97f6eba509160/tap2junit/__main__.py#L11
3. refack commented on Oct 3, 2018

   

   refack

   on Oct 3, 2018

   Last edited by refack

   Contributor

   More actions

   To fix (1) we need to land nodejs/node#23182
   I've temporarily made that fail be "unstable" instead of hard fail
4. github-actions commented on Mar 7, 2020

   

   github-actionsBot

   on Mar 7, 2020

   More actions

   This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is remove or a comment is made.
5. github-actions

   added

   stale

   on Mar 7, 2020
6. github-actions

   closed this as completedon Apr 7, 2020