Skip to content

run make test-v8-updates as a sub-job of node-test-commit-v8-linux #1342

Closed

Description

@mmarchini

As discussed in #1274 and nodejs/node#20783, we should add a sub-job to node-test-commit-v8-linux which runs make test-v8-updates on a Ubuntu 16.04 machine, otherwise tests for missing postmortem metadata and for Linux perf won't run during V8 updates.

Activity

  1. maclover7 commented on Jun 14, 2018

    @maclover7
    Contributor

    @mmarchini Can you please prepare the full bash script for the job, and then I can drop that into a new job and setup the configuration for you

  2. mmarchini commented on Jun 14, 2018

    @mmarchini
    ContributorAuthor

    Sure. The script should look like https://github.com/nodejs/build/pull/1329/files, right?

  3. mmarchini commented on Jun 18, 2018

    @mmarchini
    ContributorAuthor

    v8-updates are running for node-test-commit-v8-linux, so this can be closed.

    Ref: #1344 and #1344 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions