This repository was archived by the owner on Nov 28, 2020. It is now read-only.
Repository navigation
doc: Adding help for core benchmark in jenkins - #144
Closed
gareth-ellis wants to merge 2 commits into
Closed
gareth-ellis wants to merge 2 commits into
gareth-ellis wants to merge 2 commits into
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Member
|
@nodejs/benchmarking any other comments ? |
Member
Author
|
Comments addressed |
mhdawson
pushed a commit
that referenced
this pull request
Oct 3, 2017
PR-URL: #144 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Member
|
Landed as 8eb28ef |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First draft of document for running core benchmarks through jenkins.
@nodejs/benchmarking , please take a look, have a go at running the benchmarks (preferably start with a small subset!), and give feedback on this doc.
Likewise if you come across any functional issues, please comment in #127