avoid CI typos #26

Activity

1. vsemozhetbyt commented on Mar 24, 2018

   

   vsemozhetbyt

   on Mar 24, 2018

   Last edited by vsemozhetbyt

   More actions

   As an awkward workaround till this is done properly, I can suggest a tiny bookmarklet with a new Google Chrome clipboard API (available since v66):

   javascript: {
     (async () => {
       try {
         const PR_ID = location.pathname.replace(/.+\/pull\/(\d+).*/, '$1');
   
         if (confirm(`Create CI for #${PR_ID} ("${document.title}")?`)) {
           await navigator.clipboard.writeText(PR_ID);
           open('https://ci.nodejs.org/job/node-test-pull-request/build?delay=0sec');
         }
       } catch (err) {
         alert(err);
       }
     })();
   }

   It asks if the PR is an intended one, copies its ID to the clipboard and opens CI form.
2. priyank-p commented on Mar 24, 2018

   

   priyank-p

   on Mar 24, 2018

   More actions

   The way @vsemozhetbyt suggested could be easily done in node-review and it's a perfect place for it.
3. richardlau commented on Mar 25, 2018

   

   richardlau

   on Mar 25, 2018

   Member

   More actions

   When the github bot was able to start citgm CI runs on request, it worked by collaborators posting a comment in the PR @-mentioning the bot which would then work out the correct parameters. It worked really well when it worked and would be a good long term solution.

   👍React with 👍2Reacted by Rich Trott and Vse Mozhe Buty
4. joyeecheung commented on Mar 26, 2018

   

   joyeecheung

   on Mar 26, 2018

   Last edited by joyeecheung

   Member

   More actions

   have git node land check the CI parameters to make sure they match the PR number? (That's a big request and would probably be sloooooow.)

   Not really, actually, unless the Jenkins is stucked for some reason. All you need is an additional request to the Jenkins API. In case anyone is interested, here is how you can figure out the PRID from a build (code copy-pasted from nodejs/node-core-utils#161, and from my experience using that PR to get the CI results (~3-5 req per PR failed by flakes) , the request is pretty fast if Jenkins is not stucked):

   // request a build with the suffix api/json/?tree=actions[parameters[name,value]]
   // e.g. https://ci.nodejs.org/job/node-test-pull-request/13871/api/json?tree=actions[parameters[name,value]]
   // https://ci.nodejs.org/job/node-test-commit/17170/api/json?tree=actions[parameters[name,value]]
   
     get sourceURL() {
       const { params } = this;
   
       if (params.PR_ID) {  // from a node-test-pull-request build
         const owner = params.TARGET_GITHUB_ORG;
         const repo = params.TARGET_REPO_NAME;
         const prid = params.PR_ID;
         return `https://github.com/${owner}/${repo}/pull/${prid}/`;
       }
   
       if (params.GITHUB_ORG) {  // from a node-test-commit build
         const owner = params.GITHUB_ORG;
         const repo = params.REPO_NAME;
         const prm = params.GIT_REMOTE_REF.match(/refs\/pull\/(\d+)\/head/);
         if (prm) {
           return `https://github.com/${owner}/${repo}/pull/${prm[1]}/`;
         } else {
           const result =
             `https://api.github.com/repos/${owner}/${repo}/git/` +
             params.GIT_REMOTE_REF;
           return result;
         }
       }
     }
5. gibfahn commented on Mar 26, 2018

   

   gibfahn

   on Mar 26, 2018

   Member

   More actions

   When the github bot was able to start citgm CI runs on request, it worked by collaborators posting a comment in the PR @-mentioning the bot which would then work out the correct parameters. It worked really well when it worked and would be a good long term solution.

   Most recently discussed in nodejs/build#1180, agreed that this is the best solution long-term.

   I like the idea of git node metadata warning if the PR-URL doesn't match, given that it's already telling you whether CI was run or not.
6. Trott commented on Apr 22, 2023

   

   Trott

   on Apr 22, 2023

   MemberAuthor

   More actions

   Unarchived this repo so I could close all the PRs and issues. Will re-archive when I'm done.
7. Trott

   closed this as completedon Apr 22, 2023