Skip to content

feat(legacy-html): don't minify assets, add assets to c8 exclude #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .c8rc.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
{
"all": true
"all": true,
"exclude": [
"eslint.config.mjs",
"**/fixtures",
"src/generators/legacy-html/assets"
]
}
10 changes: 3 additions & 7 deletions codecov.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@ coverage:
target: 80%
project:
default:
# TODO(@avivkeller): Once our coverage > 70%,
# increase this to 70%, and increase on increments
target: 60%

ignore:
- 'eslint.config.mjs'
- '**/fixtures/'
# TODO(@avivkeller): Once our coverage > 80%,
# increase this to 80%, and increase on increments
target: 70%
2 changes: 1 addition & 1 deletion eslint.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,6 @@ export default [
},
{
files: ['src/generators/legacy-html/assets/*.js'],
languageOptions: { globals: { ...globals.browser } },
languageOptions: { globals: { ...globals.browser }, ecmaVersion: 'latest' },
},
];
2 changes: 0 additions & 2 deletions src/generators/legacy-html-all/index.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,6 @@ export default {
// We minify the html result to reduce the file size and keep it "clean"
const minified = await minify(generatedAllTemplate, {
collapseWhitespace: true,
minifyJS: true,
minifyCSS: true,
});

if (output) {
Expand Down
Loading
Loading