Skip to content

chore: Add remark-lint problem matcher #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mhdawson merged 1 commit into from
Mar 31, 2021
Merged

chore: Add remark-lint problem matcher #997

mhdawson merged 1 commit into from
Mar 31, 2021

Conversation

@nschonni
Copy link
Member

@nschonni nschonni commented Mar 18, 2021

Pulled from nodejs/node so there are inline comments on the Files tab of a PR for affected lines

Trott
Trott approved these changes Mar 20, 2021
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

mhdawson
mhdawson approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson merged commit 9a615ae into nodejs:main Mar 31, 2021
@nschonni nschonni deleted the remark-problem-matcher branch March 31, 2021 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@Trott Trott Trott approved these changes

@mhdawson mhdawson mhdawson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nschonni @Trott @mhdawson