Update OpenSSL Strategy for OpenSSL 3.x #859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
jasnell
approved these changes
May 1, 2020
sam-github
commented
May 1, 2020
OpenSSL-Strategy.md
Outdated
| * Default minimum TLS version is TLSv1.2, default maximum is TLSv1.3. TLSv1 | ||
| and TLSv1.1 are *not* supported by default, only by explicit run-time | ||
| configuration. | ||
| * FIPS: not supported |
Contributor
Author
There was a problem hiding this comment.
or, maybe supported? it could happen.
Member
There was a problem hiding this comment.
Current expectation, as I understand it, is that the FIPS provider should be available by the end of the year
Member
There was a problem hiding this comment.
Even if it comes for a later version in the 3.x as long as it's not breaking we should be able to get to FIPs as well. Therefore, it is more of a "maybe" at this point.
cjihrig
approved these changes
May 1, 2020
mcollina
approved these changes
May 1, 2020
Member
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
lgtm, this look a lot of work.
mhdawson
reviewed
May 4, 2020
| not an appropriate choice for 16.x | ||
|
|
||
| For minimal disruption, it would probably be helpful if Node.js supported | ||
| building against OpenSSL 1.1.1 out-of-tree, even if OpenSSL 3.x was in-tree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.