Start a vote on require(esm) markers #1621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow-up to the naming bikeshed in nodejs/loaders#221 which is for the implementation in nodejs/node#54563 A summary can be found in nodejs/node#54563 (review)
|
cc @nodejs/tsc @nodejs/loaders @guybedford |
guybedford
suggested changes
Sep 18, 2024
There was a problem hiding this comment.
Thanks @joyeecheung for putting this together. Just added some extra notes on the add-on PR here, as it is also part of the implications here.
Co-authored-by: Guy Bedford <guybedford@gmail.com>
aduh95
approved these changes
Sep 18, 2024
guybedford
suggested changes
Sep 18, 2024
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
ShogunPanda
approved these changes
Sep 19, 2024
benjamingr
approved these changes
Sep 19, 2024
guybedford
reviewed
Sep 19, 2024
guybedford
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Thanks @joyeecheung for taking on board the feedback, happy to go ahead, and as I say I completely commit to following whatever is voted on here.
Co-authored-by: Guy Bedford <guybedford@gmail.com>
|
I am not entirely sure how long this should wait, https://github.com/nodejs/TSC/tree/main/votes/initiateNewVote#initiate-a-new-tsc-vote just says "Once the PR has approvals", and it's been open for about 2 days with a few approvals, so I guess I'll just merge it when it passes the 48-hour mark. |
marco-ippolito
approved these changes
Sep 20, 2024
MoLow
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to the naming bikeshed in nodejs/loaders#221 which is for the implementation in nodejs/node#54563 A summary can be found in nodejs/node#54563 (review)