Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add minutes for meeting 17 July 2024 #1597

Merged
merged 4 commits into from
Jul 24, 2024

Conversation

mhdawson
Copy link
Member

No description provided.

Signed-off-by: Michael Dawson <midawson@redhat.com>
Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com>
@mhdawson
Copy link
Member Author

@nschonni, @Trott I see you two had the most involvement in setting up the linting. It's been driving me a bit crazy that it complains about whitespace but does not identify what line is the problem. Is that the way it should be working?

@nschonni
Copy link
Member

it seems like the https://github.com/nodejs/TSC/blob/main/.github/workflows/remark-lint-problem-matcher.json isn't commenting on the particular line, because the output isn't including the line details anymore. I'll see if I can figure out what broke.

@nschonni
Copy link
Member

nschonni commented Jul 17, 2024

OK, did some digging, and it looks like that rule is actually a custom one from @Trott https://github.com/Trott/remark-lint-no-trailing-spaces. Maybe it needs an update for an api change in remark.

EX: I updated the remark-preset-lint-node to the latest, and it flagged a few new things (and correctly indicated the line/column of the issue). I had manually edited the ONBOARDING.md to have a trailing space outside an IDE, since EditorConfig autofixes it in VSCode

$ npm test

> tsc@1.0.0 test
> remark -qf .

meetings\io.js\2015-04-08.md
16:52-16:72 warning Unexpected reference to undefined definition, expected corresponding definition (`comment by @mikeal`) for a link or escaped opening bracket (`\[`) for regular text                       no-undefined-references remark-lint
17:50-17:92 warning Unexpected reference to undefined definition, expected corresponding definition (`comments by @silverwind and @fishrock123`) for a link or escaped opening bracket (`\[`) for regular text no-undefined-references remark-lint

ONBOARDING.md
            warning Remove trailing whitespace                                                                   
                                                                                              no-trailing-spaces      remark-lint

⚠ 3 warnings

meetings/2024-07-17.md Outdated Show resolved Hide resolved
Co-authored-by: Nick Schonning <nschonni@gmail.com>
@mhdawson
Copy link
Member Author

@nschonni thanks for looking at the linter.

@Trott
Copy link
Member

Trott commented Jul 18, 2024

@nschonni @mhdawson I think when nodejs/remark-preset-lint-node#574 lands, that will generate a new release of the lint preset that will fix the issue with reporting lines and columns for trailing spaces. Unfortunately, that's currently blocked by the wonkiness we're seeing with Node.js 22 that I'm sure everyone is aware of and eager to see fixed.

@Trott
Copy link
Member

Trott commented Jul 20, 2024

OK, @mhdawson! If you rebase against origin/main and run npm ci, you should be all set. The trailing spaces linter will now tell you where to look.

@mhdawson
Copy link
Member Author

@nodejs/tsc could be good to get some approvals so I can land.

@Trott since the linter is green on this one, I'll look forward to the info for future PRs. Thanks for your help in getting it fixed.

meetings/2024-07-17.md Outdated Show resolved Hide resolved
Co-authored-by: Richard Lau <rlau@redhat.com>
@mhdawson mhdawson merged commit 5f73763 into nodejs:main Jul 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants