-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add minutes for meeting 17 July 2024 #1597
Conversation
Signed-off-by: Michael Dawson <midawson@redhat.com>
Co-authored-by: Marco Ippolito <marcoippolito54@gmail.com>
it seems like the https://github.com/nodejs/TSC/blob/main/.github/workflows/remark-lint-problem-matcher.json isn't commenting on the particular line, because the output isn't including the line details anymore. I'll see if I can figure out what broke. |
OK, did some digging, and it looks like that rule is actually a custom one from @Trott https://github.com/Trott/remark-lint-no-trailing-spaces. Maybe it needs an update for an api change in remark. EX: I updated the
|
Co-authored-by: Nick Schonning <nschonni@gmail.com>
@nschonni thanks for looking at the linter. |
@nschonni @mhdawson I think when nodejs/remark-preset-lint-node#574 lands, that will generate a new release of the lint preset that will fix the issue with reporting lines and columns for trailing spaces. Unfortunately, that's currently blocked by the wonkiness we're seeing with Node.js 22 that I'm sure everyone is aware of and eager to see fixed. |
OK, @mhdawson! If you rebase against origin/main and run |
@nodejs/tsc could be good to get some approvals so I can land. @Trott since the linter is green on this one, I'll look forward to the info for future PRs. Thanks for your help in getting it fixed. |
Co-authored-by: Richard Lau <rlau@redhat.com>
No description provided.