Vote on prefix-only core modules #1206

aduh95 · 2022-04-06T18:58:31Z

The voting options were presented in a private email instead of a public issue due the tight schedule, as we want to have a resolution before Node.js v18.x semver cutoff which is next week.

Use one of the following methods to case a vote (or abstain):

Vote using npx+gh (requires Node.js 16+, and git)

Requires gh (GitHub CLI tool) to be installed, and logged in to your GitHub account.

npx --package=@aduh95/caritat voteOnGitHub https://github.com/nodejs/TSC/pull/1206

If you want to abstain, you can use the --abstain flag (it will create a ballot with all the scores set to 0):

npx --package=@aduh95/caritat voteOnGitHub https://github.com/nodejs/TSC/pull/1206 --abstain

Vote using npx (requires Node.js 16+, and git)

# Cloning and pushing using SSH
npx --package=@aduh95/caritat voteUsingGit -r git@github.com:nodejs/TSC.git \
  -b vote-prefix-only-core-modules -p votes/prefix-only-core-modules

# Cloning and pushing using HTTPS
USERNAME=<your-github-handle> \
npx --package=@aduh95/caritat voteUsingGit -r https://$USERNAME@github.com/nodejs/TSC.git \
  -b vote-prefix-only-core-modules -p votes/prefix-only-core-modules --handle "$USERNAME"

# To abstain, use the flag --abstain
npx --package=@aduh95/caritat voteUsingGit -r git@github.com:nodejs/TSC.git \
  -b vote-prefix-only-core-modules -p votes/prefix-only-core-modules --abstain

Vote using sh (requires git, and OpenSSL CLI)

Caution: LibreSSL CLI is not compatible, please use OpenSSL 1.1.1+.

curl -LOJ https://github.com/stduhpf/caritat/raw/HEAD/sh/voteUsingGit.sh
curl -LOJ https://github.com/stduhpf/caritat/raw/HEAD/sh/encryptBallot.sh
chmod +x encryptBallot.sh
sh ./voteUsingGit.sh \
  <your-github-handle> \
  git@github.com:nodejs/TSC.git \
  vote-prefix-only-core-modules \
  votes/prefix-only-core-modules
rm encryptBallot.sh
rm voteUsingGit.sh

Vote using PowerShell (requires git, and OpenSSL CLI)

Caution: LibreSSL CLI is not compatible, please use OpenSSL 1.1.1+.

Set-ExecutionPolicy Bypass -Scope Process -Force
[System.Net.ServicePointManager]::SecurityProtocol = [System.Net.ServicePointManager]::SecurityProtocol -bor 3072
$tmpFile = $(New-TemporaryFile | Rename-Item -NewName { $_ -replace 'tmp$', 'ps1'} -PassThru)
$encryptBallot = $tmpFile -replace '\\[^\\]+$','\encryptBallot.ps1'
((New-Object System.Net.WebClient).DownloadString('https://raw.githubusercontent.com/stduhpf/caritat/HEAD/sh/voteUsingGit.ps1')) | Out-File -FilePath $tmpFile
((New-Object System.Net.WebClient).DownloadString('https://raw.githubusercontent.com/stduhpf/caritat/HEAD/sh/encryptBallot.ps1')) | Out-File -FilePath $encryptBallot
& $tmpFile `
  <your-github-handle> `
  git@github.com:nodejs/TSC.git `
  vote-prefix-only-core-modules `
  votes/prefix-only-core-modules
Remove-Item $encryptBallot
Remove-Item $tmpFile

Vote using the web

Fill in the ballot at https://stduhpf.github.io/caritat/#https://github.com/nodejs/TSC/pull/1206. It will copy the encrypted ballot to your clipboard.
Paste the encrypted ballot in https://github.com/nodejs/TSC/new/vote-prefix-only-core-modules/votes/prefix-only-core-modules. It's recommended to use <your-github-handle>.json for the file name.
Commit directly to the vote-prefix-only-core-modules branch.

To abstain, set all scores to 0 before encrypting the ballot.

This will encrypt a file containing your preferences, file that will be decrypted when doing the counting this week-end, Monday at the latest.

The counting will be done using the Condorcet method.

I didn't spend much time on improving the vote tools since last time, sorry for the inconvenience.

apapirovski · 2022-04-06T22:38:11Z

Might be worth updating the instructions for future iterations to include the note about this being high-to-low scoring, rather than the reverse. It's not immediately obvious.

Edit: Wanted to update this after using the npx + gh method to say — thanks for putting together this automated process! Super smooth to use & really improves the voting experience 🙏

targos · 2022-04-07T12:20:55Z

@nodejs/tsc

ljharb · 2022-04-11T16:15:18Z

What does it mean that there's two winners? Is another vote needed to choose between them?

aduh95 · 2022-04-11T16:21:30Z

Election results

Subject: node:-only core modules and built-in test runner module
End date: 2022-04-11T16:21:29.567Z
Participation: 76.19%

Results

Winning candidate: Ship the test runner as node:test and require('test') loads from userland.

Table of results

Candidate	Number of won duels
Ship the test runner as `node:test` and `require('test')` loads from userland.	6
Ship the test runner as `test_runner` (also available as `node:test_runner`, like other current core modules).	5
Ship the test runner as `node:test` and `require('test')` throws.	4
Ship the test runner as `node:test_runner` and `require('test_runner')` loads from userland.	2
Ship the test runner as `node:test_runner` and `require('test_runner')` throws.	2
Ship the test runner as `test` (also available as `node:test`, like other current core modules).	1
Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).	0

Voting data

Participants:

Anatoli Papirovski <apapirovski@mac.com>¹
Antoine du Hamel <duhamelantoine1995@gmail.com>²
Beth Griggs <bgriggs@redhat.com>³
Colin Ihrig <cjihrig@gmail.com>⁴
Danielle Adams <adamzdanielle@gmail.com>⁵
Darshan Sen <raisinten@gmail.com>⁶
Franziska Hinkelmann <franziska.hinkelmann@gmail.com>⁷
Gireesh Punathil <gpunathi@in.ibm.com>⁸
James M Snell <jasnell@gmail.com>⁹
Joyee Cheung <joyeec9h3@gmail.com>¹⁰
Matteo Collina <matteo.collina@gmail.com>¹¹
Michael Dawson <midawson@redhat.com>¹²
Michaël Zasso <targos@protonmail.com>¹³
Myles Borins <myles.borins@gmail.com>¹⁴
Rich Trott <rtrott@gmail.com>¹⁵
Richard Lau <rlau@redhat.com>¹⁶

Private key to decrypt ballots

Discarded commits

Some commits have not been taken into account when counting the ballots:

[
  {
    "commitInfo": {
      "sha": "c4cce1cec8e15fefb8e61a8b456ada282e701bfb",
      "signatureStatus": "N",
      "author": "Gireesh Punathil <gpunathi@in.ibm.com>",
      "files": [
        "votes/prefix-only-core-modules/gireeshpunathil.json"
      ]
    },
    "reason": "A more recent vote commit from this author has already been counted."
  }
]

1. Ship the test runner as node:test_runner and require('test_runner') loads from userland.
2. Ship the test runner as node:test and require('test') loads from userland.
3. Ship the test runner as node:test_runner and require('test_runner') throws.
4. Ship the test runner as node:test and require('test') throws.
5. Ship the test runner as test_runner (also available as node:test_runner, like other current core modules).
6. Ship the test runner as test (also available as node:test, like other current core modules).
7. Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).
↩
Abstained. ↩
1. Ship the test runner as node:test and require('test') loads from userland.
2. Ship the test runner as test (also available as node:test, like other current core modules).
3. Ship the test runner as node:test and require('test') throws.
4. Ship the test runner as test_runner (also available as node:test_runner, like other current core modules).
5. Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module), Ship the test runner as node:test_runner and require('test_runner') loads from userland, and Ship the test runner as node:test_runner and require('test_runner') throws.
↩
1. Ship the test runner as test_runner (also available as node:test_runner, like other current core modules).
2. Ship the test runner as node:test and require('test') loads from userland.
3. Ship the test runner as node:test and require('test') throws.
4. Ship the test runner as test (also available as node:test, like other current core modules).
5. Ship the test runner as node:test_runner and require('test_runner') loads from userland.
6. Ship the test runner as node:test_runner and require('test_runner') throws.
7. Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).
↩
1. Ship the test runner as node:test_runner and require('test_runner') throws.
2. Ship the test runner as node:test and require('test') throws and Ship the test runner as test_runner (also available as node:test_runner, like other current core modules).
3. Ship the test runner as test (also available as node:test, like other current core modules), Ship the test runner as node:test and require('test') loads from userland, and Ship the test runner as node:test_runner and require('test_runner') loads from userland.
4. Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).
↩
1. Ship the test runner as node:test and require('test') loads from userland.
2. Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).
3. Ship the test runner as test_runner (also available as node:test_runner, like other current core modules).
4. Ship the test runner as test (also available as node:test, like other current core modules).
5. Ship the test runner as node:test and require('test') throws.
6. Ship the test runner as node:test_runner and require('test_runner') loads from userland.
7. Ship the test runner as node:test_runner and require('test_runner') throws.
↩
Abstained. ↩
Voted for Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module). ↩
1. Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module) and Ship the test runner as test_runner (also available as node:test_runner, like other current core modules).
2. Ship the test runner as node:test and require('test') throws and Ship the test runner as node:test_runner and require('test_runner') throws.
3. Ship the test runner as test (also available as node:test, like other current core modules), Ship the test runner as node:test and require('test') loads from userland, and Ship the test runner as node:test_runner and require('test_runner') loads from userland.
↩
1. Ship the test runner as node:test and require('test') loads from userland.
2. Ship the test runner as node:test and require('test') throws.
3. Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module), Ship the test runner as test (also available as node:test, like other current core modules), Ship the test runner as test_runner (also available as node:test_runner, like other current core modules), Ship the test runner as node:test_runner and require('test_runner') loads from userland, and Ship the test runner as node:test_runner and require('test_runner') throws.
↩
1. Ship the test runner as node:test and require('test') loads from userland.
2. Ship the test runner as test_runner (also available as node:test_runner, like other current core modules).
3. Ship the test runner as node:test_runner and require('test_runner') loads from userland and Ship the test runner as node:test_runner and require('test_runner') throws.
4. Ship the test runner as node:test and require('test') throws.
5. Ship the test runner as test (also available as node:test, like other current core modules).
6. Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).
↩
1. Ship the test runner as node:test and require('test') loads from userland.
2. Ship the test runner as node:test_runner and require('test_runner') loads from userland.
3. Ship the test runner as node:test and require('test') throws.
4. Ship the test runner as node:test_runner and require('test_runner') throws.
5. Ship the test runner as test_runner (also available as node:test_runner, like other current core modules).
6. Ship the test runner as test (also available as node:test, like other current core modules).
7. Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).
↩
1. Ship the test runner as test (also available as node:test, like other current core modules) and Ship the test runner as test_runner (also available as node:test_runner, like other current core modules).
2. Ship the test runner as node:test and require('test') throws.
3. Ship the test runner as node:test and require('test') loads from userland and Ship the test runner as node:test_runner and require('test_runner') throws.
4. Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module) and Ship the test runner as node:test_runner and require('test_runner') loads from userland.
↩
Abstained. ↩
Voted against Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module), Ship the test runner as test (also available as node:test, like other current core modules), and Ship the test runner as node:test and require('test') throws. ↩
1. Ship the test runner as test_runner (also available as node:test_runner, like other current core modules).
2. Ship the test runner as node:test_runner and require('test_runner') throws.
3. Ship the test runner as node:test and require('test') loads from userland and Ship the test runner as node:test and require('test') throws.
4. Ship the test runner as node:test_runner and require('test_runner') loads from userland.
5. Ship the test runner as test (also available as node:test, like other current core modules).
6. Do not expose the test runner as a new core module (revert it before v18.0.0 is released, the test runner can be reintroduced later by exposing it on an existing core module).
↩

Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>

ljharb · 2022-04-12T03:05:08Z

So we're ok with users expecting node:foo and foo to be the same thing, but node:test and test not to be?

(apologies for the misclose)

Trott · 2022-04-12T14:26:09Z

The Charter says:

For all votes, a simple majority of all TSC members for, or against, the issue wins. A TSC member may choose to participate in any vote through abstention.

So we should be able to have (hopefully again, very quick) a yes-or-no vote on the winner and make sure that at least 11 members (or whatever number of members is a majority once you account for explicit abstentions) are in favor of it.

If the system is working as intended, then this should pass without a problem. If it doesn't, then that may indicate a problem with the voting system. (We may, for example, need to require all members to participate for the condorcet system to work within the charter guidelines.)

I'm bringing this up because the vote was close. We don't normally have a close vote on anything, so this isn't usually an issue.

ljharb · 2022-04-12T20:33:28Z

@Trott we also don't have any reason to believe they wouldn't - i think out of about 50 such requests over the last decade, i've only ever had 2-3 turn me down. @Gozala - any chance you'd be willing to do that?

Trott · 2022-04-13T14:50:24Z

As I write this, there are 7 TSC votes in favor, 1 against, and 4 abstentions on the finalizing vote comment. We need at least 2 more TSC folks to participate, possibly more, to come to a resolution. I can't make the TSC meeting today, but if folks who are there could remind anyone there who hasn't voted yet, that would be helpful.

Trott · 2022-04-13T19:27:23Z

As I write this, there are 7 TSC votes in favor, 1 against, and 4 abstentions on the finalizing vote comment. We need at least 2 more TSC folks to participate, possibly more, to come to a resolution. I can't make the TSC meeting today, but if folks who are there could remind anyone there who hasn't voted yet, that would be helpful.

One more abstention or yes vote from a @nodejs/tsc member will bring the vote to a close in conformance with our charter.

ChALkeR · 2022-04-13T21:06:48Z

I think that happened now ).

Gozala · 2022-04-13T21:41:05Z

@Trott we also don't have any reason to believe they wouldn't - i think out of about 50 such requests over the last decade, i've only ever had 2-3 turn me down. @Gozala - any chance you'd be willing to do that?

@ljharb Are you asking if I'm willing to hand over the 'test' package to the node core ? If so, I would not mind doing that. If it is a different ask please provide some more info as I lack context.

That said I would much rather see prefixed node modules however as more conflicts undoubtedly would occur over time.

ljharb · 2022-04-13T21:42:04Z

@Gozala yep, that's what i was asking! I'm pleased to hear you'd be open to it.

mhdawson

LGTM

- updated based on decision to use node: prefix in nodejs/TSC#1206 - updated based on agreement in TSC meeting on adding /promises to existing modules as per minutes - nodejs/TSC#1281 Signed-off-by: Michael Dawson <mdawson@devrus.com>

- updated based on decision to use node: prefix in nodejs/TSC#1206 - updated based on agreement in TSC meeting on adding /promises to existing modules as per minutes - nodejs/TSC#1281 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #44576 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

- updated based on decision to use node: prefix in nodejs/TSC#1206 - updated based on agreement in TSC meeting on adding /promises to existing modules as per minutes - nodejs/TSC#1281 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs/node#44576 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

aduh95 and others added 4 commits April 6, 2022 20:48

Vote on node:-only core modules

35a43f0

vote from aduh95

4a22bdb

vote from cjihrig

cf70874

vote from mhdawson

c03f164

apapirovski and others added 9 commits April 6, 2022 15:46

vote from apapirovski

82cabaa

vote from Rich Trott

e14b802

vote from fhinkel

e9b7b5b

vote from RaisinTen

20ab018

vote from targos

aaae162

vote from gireeshpunathil

c4cce1c

vote from Matteo Collina

2b8a651

vote from Richard Lau

26d6a01

vote from Beth Griggs

49198b5

vote from gireeshpunathil

e0a66c4

aduh95 changed the title ~~Vote prefix only core modules~~ Vote on prefix-only core modules Apr 7, 2022

danielleadams and others added 4 commits April 10, 2022 10:34

vote from Danielle Adams

ac8ad52

Vote for test runner node prefix

c4b2b45

vote from MylesBorins

6a8f976

close vote and aggregate results

990e77d

add vote from joyeecheung

93e32e0

Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>

aduh95 requested a review from joyeecheung April 12, 2022 03:00

ljharb closed this Apr 12, 2022

ljharb reopened this Apr 12, 2022

joyeecheung approved these changes Apr 12, 2022

View reviewed changes

Trott mentioned this pull request Apr 13, 2022

Node.js Technical Steering Committee (TSC) Meeting 2022-04-13 #1209

Closed

close vote and aggregate results

ea4fddc

aduh95 requested a review from Trott April 13, 2022 22:13

mhdawson approved these changes Apr 13, 2022

View reviewed changes

Trott approved these changes Apr 14, 2022

View reviewed changes

Trott merged commit 8fcbb34 into main Apr 14, 2022

aduh95 deleted the vote-prefix-only-core-modules branch April 14, 2022 09:13

aduh95 mentioned this pull request May 1, 2022

Transfer juliangruber/node-core-test in the Node.js org nodejs/admin#683

Closed

achrinza mentioned this pull request May 7, 2022

Settle on a voting solution loopbackio/loopback-governance#33

Open

mhdawson mentioned this pull request Sep 8, 2022

doc: update guidance for adding new modules nodejs/node#44576

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Vote on prefix-only core modules #1206

Vote on prefix-only core modules #1206

aduh95 commented Apr 6, 2022 •

edited

Loading

apapirovski commented Apr 6, 2022 •

edited

Loading

targos commented Apr 7, 2022

ljharb commented Apr 11, 2022

aduh95 commented Apr 11, 2022 •

edited

Loading

ljharb commented Apr 12, 2022 •

edited

Loading

Trott commented Apr 12, 2022 •

edited

Loading

ljharb commented Apr 12, 2022

Trott commented Apr 13, 2022

Trott commented Apr 13, 2022

ChALkeR commented Apr 13, 2022

Gozala commented Apr 13, 2022

ljharb commented Apr 13, 2022

mhdawson left a comment

Vote on prefix-only core modules #1206

Vote on prefix-only core modules #1206

Conversation

aduh95 commented Apr 6, 2022 • edited Loading

apapirovski commented Apr 6, 2022 • edited Loading

targos commented Apr 7, 2022

ljharb commented Apr 11, 2022

aduh95 commented Apr 11, 2022 • edited Loading

Election results

Results

Table of results

Voting data

Footnotes

ljharb commented Apr 12, 2022 • edited Loading

Trott commented Apr 12, 2022 • edited Loading

ljharb commented Apr 12, 2022

Trott commented Apr 13, 2022

Trott commented Apr 13, 2022

ChALkeR commented Apr 13, 2022

Gozala commented Apr 13, 2022

ljharb commented Apr 13, 2022

mhdawson left a comment

Choose a reason for hiding this comment

aduh95 commented Apr 6, 2022 •

edited

Loading

apapirovski commented Apr 6, 2022 •

edited

Loading

aduh95 commented Apr 11, 2022 •

edited

Loading

ljharb commented Apr 12, 2022 •

edited

Loading

Trott commented Apr 12, 2022 •

edited

Loading