-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nominating Chengzhong Wu (@legendecas) to the TSC #1282
Comments
+1 assuming is up for it :) |
I should have mentioned I have talked to Chengzhong and he is interested. |
+1 |
3 similar comments
+1 |
+1 |
+1 |
+1 for sure! |
+1 |
2 similar comments
+1 |
+1 |
By my count we have 14/20 +1s so far and no objections. I will wait until after the TSC meeting this week and then close the vote (The goverance says I'll volunteer to onboard @legendecas assuming the vote is positive. Anybody else want to join us? |
Ok, TSC meeting passed, and no objections so considering vote complete with a yes. PR to add vote data - #1284 |
@legendecas I'll co-ordinate with you for the onboarding separately:
|
@legendecas can you confirm:
|
PR to add Chengzhong to invited list for TSC meetings - https://github.com/nodejs/create-node-meeting-artifacts/pull/118/files |
PR to add to mailing lists - nodejs/email#197 |
PR to add to TSC list in README.md - nodejs/node#44662 |
Refs: nodejs/TSC#1282 Signed-off-by: Michael Dawson <mdawson@devrus.com>
I confirm I understand and agree to uphold the code of conduct. |
Refs: nodejs/TSC#1282 Signed-off-by: Michael Dawson <mdawson@devrus.com>
Working through the list, only a few more items that I should get to tomorrow. @legendecas maybe we can talk after the Node-API team meeting tomorrow and I can give you some context and answer any questions you have? |
Sure, that will be great, thank you! |
Refs: nodejs/TSC#1282 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #44662 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
I think the only thing left to do is to add @legendecas to HackerOne (and maybe to the Google Group--I didn't check that one). @mhdawson Let me know if you want me to handle HackerOne or find someone to handle the Google Group. Otherwise, I'll assume you're waiting to talk to @legendecas about something first or something like that. |
Ok all done. |
Refs: nodejs/TSC#1282 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #44662 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Refs: nodejs/TSC#1282 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #44662 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Refs: nodejs/TSC#1282 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #44662 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Refs: nodejs/TSC#1282 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #44662 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Refs: nodejs/TSC#1282 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #44662 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Refs: nodejs/TSC#1282 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #44662 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Refs: nodejs/TSC#1282 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #44662 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Refs: nodejs/TSC#1282 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #44662 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Refs: nodejs/TSC#1282 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: #44662 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Refs: nodejs/TSC#1282 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs/node#44662 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Refs: nodejs/TSC#1282 Signed-off-by: Michael Dawson <mdawson@devrus.com> PR-URL: nodejs/node#44662 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
I'd like to nominate Chengzhong Wu (@legendecas)[https://github.com/legendecas].
He has contributed over a number of years and has 83 commits to Node.js core, has been involved in 440 issues in node.js core and is a significant contributor to Node-api and the work of the Node-api team. He has also been contributing to diagnostic efforts and is leading the ShadowRealm initiative.
He's been very collaborative, contributes in a thoughtful and respectful way, and works to help move the work of the project forward in a scope greater than individual commits/issues. I've enjoyed my interactions with him and I think he'd be a good addition to the TSC.
The text was updated successfully, but these errors were encountered: