Skip to content

backport indentation changes #239

Closed
Closed

Description

@MylesBorins

/cc @Trott

Activity

  1. Trott commented on Aug 15, 2017

    @Trott
    Member

    Can I do each of these in turn, preserving metadata in the commits, but then submitting one mega-backport PR for them?

  2. Trott commented on Aug 15, 2017

    @Trott
    Member

    #10479 should probably happen as well and first. I'll include it in my mega-PR (if it's OK to mega-PR this).

  3. Trott commented on Aug 15, 2017

    @Trott
    Member

    #14417 is a no-op when applied to v6.x-staging, so it can be left out.

  4. Trott commented on Aug 15, 2017

    @Trott
    Member

    This also needs the ESLint updates for bug fixes.

  5. Trott commented on Aug 15, 2017

    @Trott
    Member

    Will need nodejs/node#13950 too.

  6. Trott commented on Aug 15, 2017

    @Trott
    Member

    All backported in nodejs/node#14835

  7. MylesBorins commented on Aug 16, 2017

    @MylesBorins
    ContributorAuthor

    Lovely!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions