failures on aix v6.x-staging #218

Activity

1. MylesBorins commented on May 16, 2017

   

   MylesBorins

   on May 16, 2017

   ContributorAuthor

   More actions

   we may need to land nodejs/node#10085, but this is unrelated to the compiler failure

   /cc @mhdawson
2. MylesBorins commented on May 16, 2017

   

   MylesBorins

   on May 16, 2017

   ContributorAuthor

   More actions

   It looks like the failure is specific to two member function not existing in v8::internal

   ../deps/v8/src/builtins/ppc/builtins-ppc.cc:672:76: error: no 'void v8::internal::Builtins::Generate_JSBuiltinsConstructStubForBase(v8::internal::MacroAssembler*)' member function declared in class 'v8::internal::Builtins'
    void Builtins::Generate_JSBuiltinsConstructStubForBase(MacroAssembler* masm) {
                                                                               ^
   ../deps/v8/src/builtins/ppc/builtins-ppc.cc:677:25: error: no 'void v8::internal::Builtins::Generate_JSBuiltinsConstructStubForDerived(v8::internal::MacroAssembler*)' member function declared in class 'v8::internal::Builtins'
        MacroAssembler* masm) {
                            ^
   ../deps/v8/src/builtins/ppc/builtins-ppc.cc: In static member function 'static void v8::internal::Builtins::Generate_CompileLazy(v8::internal::MacroAssembler*)':
   ../deps/v8/src/builtins/ppc/builtins-ppc.cc:1359:33: error: 'kOptimizedCodeMapOffset' is not a member of 'v8::internal::SharedFunctionInfo'
               FieldMemOperand(map, SharedFunctionInfo::kOptimizedCodeMapOffset));
   
3. MylesBorins commented on May 16, 2017

   

   MylesBorins

   on May 16, 2017

   ContributorAuthor

   More actions

   /cc @nodejs/v8
4. jeisinger commented on May 16, 2017

   

   jeisinger

   on May 16, 2017

   More actions

   that might be because the ppc port didn't yet port over https://chromium-review.googlesource.com/c/489525/

   👍React with 👍1Reacted by Myles Borins
5. rmcilroy commented on May 16, 2017

   

   rmcilroy

   on May 16, 2017

   More actions

   Actually from looking at the errors I think it's because they've not yet ported over https://chromium-review.googlesource.com/c/500134/. They did port it over but reverted it when the original CL was reverted - shouldn't be too difficult to reland with the updates.

   👍React with 👍1Reacted by Myles Borins
6. jbajwa commented on May 16, 2017

   

   jbajwa

   on May 16, 2017

   More actions

   I'm working on porting to V8 master. I was wondering how it is affecting v6.x-staging branch where V8 is at 5.1 and the original CL was committed to V8 6.0 ?
7. jbajwa commented on May 16, 2017

   

   jbajwa

   on May 16, 2017

   More actions

   The test job linked above seems to be from the canary branch,

   Started by upstream project "node-test-commit-aix" build number 5891
   originally caused by:
    Started by upstream project "node-test-commit-node-v8" build number 16
    originally caused by:
     Started by upstream project "node-update-v8-canary" build number 30
     originally caused by:
      Started by timer
   
8. targos commented on May 16, 2017

   

   targos

   on May 16, 2017

   Member

   More actions

   This failure is from the node-update-v8-canary job. It shouldn't be related to v6.x-staging.
9. MylesBorins commented on May 16, 2017

   

   MylesBorins

   on May 16, 2017

   ContributorAuthor

   More actions

   OH LOL... I messed that up This is unrelated to staging. Sorry for the fire drill 😄

   😄React with 😄1Reacted by Gibson Fahnestock
10. MylesBorins

    closed this as completedon May 16, 2017