Update to remove old kafka modules#154
Conversation
rob3000
force-pushed
the
master
branch
2 times, most recently
from
4571439 to
641c169
Compare
|
Looking good @rob3000 I am on the road currently, going to have a look at this on the weekend. |
krystianity
left a comment
krystianity
left a comment
There was a problem hiding this comment.
Not really a change request, more like suggestions and opinions ;)
|
@krystianity updated based on the comments you made. I've also converted to typescript. Currently admin client is failing but feel free to review :) |
… to remove volumes to ensure we can run clean. Updated CHANGELOG
|
@krystianity This is now ready for review! 🥳 |
…t client as abstract so the consumer/producer is forced to set the client
|
Awesome, will review tonight - you are really going full speed here 👍 ❤️ |
|
looking good so far, however the amount of changes is quite large so its quite difficult to approve this with 100% confidence, given the major changes we are doing anyway, we will probably have to run some in the fields tests for lag status (health and analytics) - testing this with kafka-streams will probably also be a good validation of the changes. |
|
agreed, there are lots of changes. i guess if we merge to master we can test kafka streams from the sinek's master branch which would give us better confidence? |
|
@rob3000 didnt release you were waiting for my approval to merge this, lgtm ;) |
2 participants
Removing old node modules and use kafkaJS as primary source and removed some old config.
Suggestions/comments welcome 😄
Next i'd like to update some of the documentation thoughts on using something like: https://docusaurus.io/