Skip to content

mapJSONConvenience and mapBufferKeyToString do not work dues to faulty isBuffer check #209

@tw00

Description

@tw00

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch kafka-streams@5.0.0 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/kafka-streams/lib/dsl/StreamDSL.js b/node_modules/kafka-streams/lib/dsl/StreamDSL.js
index 730c871..94a2dd0 100644
--- a/node_modules/kafka-streams/lib/dsl/StreamDSL.js
+++ b/node_modules/kafka-streams/lib/dsl/StreamDSL.js
@@ -475,7 +475,7 @@ class StreamDSL {
                 return object;
             }
 
-            if (Buffer.isBuffer(object.key)) {
+            if (!Buffer.isBuffer(object.key)) {
                 return object;
             }
 

This issue body was partially generated by patch-package.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions